907915 - Going to TopCrasher with a version we're not using should 404 instead of trying to render the page

Status: VERIFIED FIXED

(Socorro :: Webapp, task)

Description

[Peter Bengtsson [:peterbe]]

The example is when hitting /topcrasher/products/Firefox/versions/10.0a1

"10.0a1" is not a valid version in the drop-down so the URL should not be allowed.

Comment 1

[Peter Bengtsson [:peterbe]]

PR: https://github.com/mozilla/socorro/pull/1427

Comment 2

[Peter Bengtsson [:peterbe]]

Steps to reproduce:

1. Go to the homepage (/home/products/Firefox)
2. Click one of the Top Crashers links
3. Edit the URL and replace, for example "26.0a1", with something that isn't a valid version in the dropdowns, for example "6.0"

Expected outcome:
* Get a Page Not Found

Comment 3

[[github robot]]

Commit pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/8bb929be681f65ee745f4dca619a3726529caee4
fixes bug 907915 - topcrasher with invalid version should 404, r=rhelmer

Comment 4

[Matt Brandt [:mbrandt]]

QA verified on stage - incorrect products correctly redirect to a 404 instead of a 500 page

[14:08:38.384] GET https://crash-stats.allizom.org/topcrasher/products/Firefox/versions/10.0a1 [HTTP/1.1 404 NOT FOUND 460ms]
--
[14:09:14.868] GET https://crash-stats.allizom.org/topcrasher/products/Firefox/versions/satuna [HTTP/1.1 404 NOT FOUND 306ms]