Closed
Bug 907946
Opened 11 years ago
Closed 11 years ago
Re-enable EXT_packed_depth_stencil on OS X 10.9
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
mozilla26
People
(Reporter: guillaume.abadie, Assigned: guillaume.abadie)
References
Details
Attachments
(1 file, 1 obsolete file)
2.98 KB,
patch
|
bjacob
:
review+
jgilbert
:
review+
|
Details | Diff | Splinter Review |
This extension has been blacklisted on OS X 10.9 running on a Nvidia driver. But the crash described in 814839 seams to be fixed, and the WebGL conformance test is passed.
Assignee | ||
Updated•11 years ago
|
Summary: Re-enable EXT_packed_depth_stencil os OS X 10.9 → Re-enable EXT_packed_depth_stencil on OS X 10.9
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #793721 -
Flags: review?(jgilbert)
Attachment #793721 -
Flags: review?(bjacob)
Assignee | ||
Comment 2•11 years ago
|
||
I have forgotten to qrefresh before uploading... =D
Attachment #793721 -
Attachment is obsolete: true
Attachment #793721 -
Flags: review?(jgilbert)
Attachment #793721 -
Flags: review?(bjacob)
Attachment #793723 -
Flags: review?(jgilbert)
Attachment #793723 -
Flags: review?(bjacob)
Comment 3•11 years ago
|
||
Comment on attachment 793723 [details] [diff] [review] patch revision 2 Review of attachment 793723 [details] [diff] [review]: ----------------------------------------------------------------- ::: gfx/gl/GLContext.cpp @@ +830,3 @@ > if (WorkAroundDriverBugs() && > + Vendor() == gl::GLContext::VendorNVIDIA && > + !nsCocoaFeatures::OnMavericksOrLater()) We should be doing this with our blacklisting system, not hard-coded. We're not trying to use a 10.9 feature, but rather stop ourselves from using apparently broken drivers from 10.8 and earlier.
Attachment #793723 -
Flags: review?(jgilbert) → review-
Assignee | ||
Comment 4•11 years ago
|
||
Oh I see... So, why is that been done this way?
Comment 5•11 years ago
|
||
Comment on attachment 793723 [details] [diff] [review] patch revision 2 Review of attachment 793723 [details] [diff] [review]: ----------------------------------------------------------------- In theory, I agree with Jeff: it would be nice to have all these things handled by the blacklisting system. The problem is that we do not currently have in our blocklisting system a Feature for "EXT_packed_depth_stencil", so we would have to add one, that that is very dangerous with our stupid blocklisting system: if a new downloadable blacklist entry were added with that feature, it would get mis-interpreted as "all features" by older Gecko's. That has severely bitten us before. So for now --- pending the blocklisting system rewrite that has been discussed and even designed but never prioritized --- we will have to do with hardcoded checks as in the present patch. Jeff: please consider lifting the r- Guillaume: please do not land as long as there is a r-
Attachment #793723 -
Flags: review?(bjacob) → review+
Assignee | ||
Comment 6•11 years ago
|
||
For sure! Thanks!
Assignee | ||
Comment 7•11 years ago
|
||
As green as an apple : https://tbpl.mozilla.org/?tree=Try&rev=7753376c1239
Comment 8•11 years ago
|
||
(In reply to Benoit Jacob [:bjacob] from comment #5) > Comment on attachment 793723 [details] [diff] [review] > patch revision 2 > > Review of attachment 793723 [details] [diff] [review]: > ----------------------------------------------------------------- > > In theory, I agree with Jeff: it would be nice to have all these things > handled by the blacklisting system. > > The problem is that we do not currently have in our blocklisting system a > Feature for "EXT_packed_depth_stencil", so we would have to add one, that > that is very dangerous with our stupid blocklisting system: if a new > downloadable blacklist entry were added with that feature, it would get > mis-interpreted as "all features" by older Gecko's. That has severely bitten > us before. > > So for now --- pending the blocklisting system rewrite that has been > discussed and even designed but never prioritized --- we will have to do > with hardcoded checks as in the present patch. > > Jeff: please consider lifting the r- > Guillaume: please do not land as long as there is a r- Alright, that was my fear. Let's just hardcode this then.
Updated•11 years ago
|
Attachment #793723 -
Flags: review- → review+
Assignee | ||
Comment 9•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/13bbb02033f8
Comment 10•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/13bbb02033f8
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in
before you can comment on or make changes to this bug.
Description
•