907951 - [Systems] Menu bar icons are still in SD (Saved to home screen)

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Amy Lee [:amylee] UX]

Attachment: browser [e-mail]

Hi, 

There are two icons that I found in the bottom browser menu that are still in SD. I've attached the HD version to replace them.

Thanks

Comment 1

[Amy Lee [:amylee] UX]

Attachment: Systems-BrowserIcons.png

Screenshot for reference

Comment 2

[Wayne Chang [:wchang]]

HD+ asset

Comment 3

[Eric Pang [:epang] UX]

Hey Amy, where are these screens from?  I can't seem to find them, are they part of e.me (i feel like i've seen them there in the past)?

Comment 4

[Amy Lee [:amylee] UX]

(In reply to Eric Pang [:epang] from comment #3)
> Hey Amy, where are these screens from?  I can't seem to find them, are they
> part of e.me (i feel like i've seen them there in the past)?

Hi Eric, 

When you click on the star in the browser and choose "add to home screen" it saves the page on your home screen. When you click on the icon on the home screen you will see the screenshot.

Comment 5

[Eric Pang [:epang] UX]

Wow, this screen is really broken...

1. the wrong forward arrow is being used (should be the opposite of the back arrow)
2. The refresh icon is incorrect and not hd (should be 1 arrow that forms a circle)
3. The arrow on the organge bar is no HD.  

Is there a reason why we aren't using the same tool bar as browser?

Francis, can we get your input for this bug?  Thanks!

Comment 6

[Francis Djabri [:djabber]]

(In reply to Eric Pang [:epang] from comment #5)
> Wow, this screen is really broken...
> 
> 1. the wrong forward arrow is being used (should be the opposite of the back
> arrow)
> 2. The refresh icon is incorrect and not hd (should be 1 arrow that forms a
> circle)
> 3. The arrow on the organge bar is no HD.  
> 
> Is there a reason why we aren't using the same tool bar as browser?
> 
> Francis, can we get your input for this bug?  Thanks!

Hi, yes, what you're seeing is the wrapper used for e.me apps and favorited bookmarks. It uses a different tool bar because e.me apps are expected to be more self-contained and do not require as much navigation and scrolling. Therefore the chrome is minimized to allow for a content-centric experience.

Comment 7

[Eric Pang [:epang] UX]

(In reply to Francis Djabri [:djabber] from comment #6)
> (In reply to Eric Pang [:epang] from comment #5)
> > Wow, this screen is really broken...
> > 
> > 1. the wrong forward arrow is being used (should be the opposite of the back
> > arrow)
> > 2. The refresh icon is incorrect and not hd (should be 1 arrow that forms a
> > circle)
> > 3. The arrow on the organge bar is no HD.  
> > 
> > Is there a reason why we aren't using the same tool bar as browser?
> > 
> > Francis, can we get your input for this bug?  Thanks!
> 
> Hi, yes, what you're seeing is the wrapper used for e.me apps and favorited
> bookmarks. It uses a different tool bar because e.me apps are expected to be
> more self-contained and do not require as much navigation and scrolling.
> Therefore the chrome is minimized to allow for a content-centric experience.

ok, thanks Francis!

Comment 8

[Eric Pang [:epang] UX]

Attachment: Systems-BrowserIcons.png

Hi Pavel, since this wrapper is correct we'll need to update some of the icons.  I've highlighted which ones in the image.

1. Need to update the up arrow - can you help me find the current image?  Then I can resize for 1.5.

2. Use this image so it matches the back arrow: https://github.com/mozilla-b2g/gaia/blob/v1.1.0hd/apps/browser/style/images/iconaction_browser_forward_30x30%401.5x.png

3. Sync icon is still SD - I'll attached the icon.

Let me know if you have any questions, thanks!

Comment 9

[Eric Pang [:epang] UX]

Attachment: [e-mail]

Sync Icon

Comment 10

[Eric Pang [:epang] UX]

(In reply to Eric Pang [:epang] from comment #8)
> Created attachment 799454 [details]
> Systems-BrowserIcons.png
> 
> Hi Pavel, since this wrapper is correct we'll need to update some of the
> icons.  I've highlighted which ones in the image.
> 
> 1. Need to update the up arrow - can you help me find the current image? 
> Then I can resize for 1.5.
> 
> 2. Use this image so it matches the back arrow:
> https://github.com/mozilla-b2g/gaia/blob/v1.1.0hd/apps/browser/style/images/
> iconaction_browser_forward_30x30%401.5x.png
> 
> 3. Sync icon is still SD - I'll attached the icon.
> 
> Let me know if you have any questions, thanks!

Forgot to add that the forward arrow will need to be updated for SD as well, thanks!

Comment 11

[[e-mail]]

amy, can you help confirm is this bug still exist since I saw all @1.5x.png are there (not sure if they fit the quality)

Comment 12

[Eric Pang [:epang] UX]

(In reply to Fred Lin [:gasolin] from comment #11)
> amy, can you help confirm is this bug still exist since I saw all @1.5x.png
> are there (not sure if they fit the quality)

Hi Fred, this still appears to be an issue.  

Pavel, have you had a chance to work on this yet, thanks!

Comment 13

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Not yet ... but I will try to work on this tomorrow

Comment 14

[[e-mail]]

seems it caused by bug 881157 is not uplifted to v1.1.0hd

Comment 15

[(Inactive after June) George Duan [:gduan] [:喬智]]

(In reply to Fred Lin [:gasolin] from comment #14)
> seems it caused by bug 881157 is not uplifted to v1.1.0hd
This commit should have these icons and it has already been merged into hd branch.
https://github.com/mozilla-b2g/gaia/pull/10884/files

Comment 16

[Wayne Chang [:wchang]]

(In reply to George Duan [:gduan] from comment #15)
> (In reply to Fred Lin [:gasolin] from comment #14)
> > seems it caused by bug 881157 is not uplifted to v1.1.0hd
> This commit should have these icons and it has already been merged into hd
> branch.
> https://github.com/mozilla-b2g/gaia/pull/10884/files

Can we close this as resolved fixed ?

Comment 17

[Wayne Chang [:wchang]]

(In reply to Wayne Chang [:wchang] from comment #16)

> Can we close this as resolved fixed ?

George can you confirm this?

Comment 18

[(Inactive after June) George Duan [:gduan] [:喬智]]

Hi Wayne,

Sorry, I only replied comment 14 that I've already checked in up/reload/forward hd images as below. 

https://github.com/mozilla-b2g/gaia/blob/v1.1.0hd/apps/system/style/wrapper/images/forward%401.5x.png
https://github.com/mozilla-b2g/gaia/blob/v1.1.0hd/apps/system/style/wrapper/images/reload%401.5x.png
https://github.com/mozilla-b2g/gaia/blob/v1.1.0hd/apps/system/style/wrapper/images/open%401.5x.png

Hi, Eric,
Above images will be used in hd device, could you check whether they are correct or not?

And you'd like to replace the forward icon of all branches, not only hd, right?

Comment 19

[Eric Pang [:epang] UX]

Attachment: [e-mail]

Hi George, thanks for working on this.  2 of the icons look correct (refresh and up arrow button), but this should be the forward arrow used, so it matches the back arrow.  Yes please update on all branches.

Comment 20

[(Inactive after June) George Duan [:gduan] [:喬智]]

I think you also need to give me @1x.png ?

Comment 21

[Eric Pang [:epang] UX]

Attachment: actionicon_forward.png

sorry, I've attached it now. thanks!

Comment 22

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: PR to master

Hi Alive, 
this patch has updated the images as Eric suggest, please kindly check.
Thanks.

Comment 23

[(Inactive after June) George Duan [:gduan] [:喬智]]

Merge into master,
https://github.com/mozilla-b2g/gaia/commit/9a50b852fa0fb447cfa43b07ae21e8427f705236

Comment 24

[(Inactive after June) George Duan [:gduan] [:喬智]]

Uplift to v1-train,
https://github.com/mozilla-b2g/gaia/commit/86163ce443e3a5b5093c6143f8646df54b658ec5
Uplift to v1.1.0hd,
https://github.com/mozilla-b2g/gaia/commit/bb081fcb924941be28c5745e81c6d6983196e233
Uplift to v1.2,
https://github.com/mozilla-b2g/gaia/commit/6d84d5953eee84fd32671d0b7fb3976d6e2961c4

Comment 25

[Ryan VanderMeulen [:RyanVM]]

This isn't leo+, so I don't believe this should be on v1-train. Assuming that's the case, please backout from there and change status-b2g18 to wontfix.

Comment 26

[Tim Guan-tin Chien [:timdream] (please needinfo)]

v1.1.0hd: 86163ce443e3a5b5093c6143f8646df54b658ec5

Comment 27

[(Inactive after June) George Duan [:gduan] [:喬智]]

Sorry, it's my mistake.
https://github.com/mozilla-b2g/gaia/commit/b585b32441fafa67f2b4582db23be5f3a2afab21

(In reply to Ryan VanderMeulen [:RyanVM UTC-5] from comment #25)
> This isn't leo+, so I don't believe this should be on v1-train. Assuming
> that's the case, please backout from there and change status-b2g18 to
> wontfix.

Comment 28

[Tim Guan-tin Chien [:timdream] (please needinfo)]

v1.1.0hd: b585b32441fafa67f2b4582db23be5f3a2afab21

Comment 29

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Please ensure semi-automatic uplift script does mess-up v1.1.0hd.

Comment 30

[(Inactive after June) George Duan [:gduan] [:喬智]]

Thanks for reminding. Push back the [e-mail] to v1.1.0hd.

https://github.com/mozilla-b2g/gaia/commit/ff5fdef17c997deb000c386c809dbf2617656c9b

Comment 31

[William Hsu [:whsu]]

Thanks for the help!
Verified it.

Attaching the screenshot.

* Test Build:
 - Gaia:     ff5fdef17c997deb000c386c809dbf2617656c9b
 - Gecko:    http://hg.mozilla.org/releases/mozilla-b2g18_v1_1_0_hd/rev/42e2dbb0d538
 - BuildID   20131121042202
 - Version   18.0

Comment 32

[William Hsu [:whsu]]

Attachment: Menu bar icons