Closed Bug 907968 Opened 7 years ago Closed 7 years ago

Build fails with Japanese Windows, again and again

Categories

(Firefox Build System :: Mach Core, enhancement)

enhancement
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla26

People

(Reporter: emk, Assigned: emk)

Details

Attachments

(1 file)

$ mach build
 0:00.62 C:/mozilla-build/msys/bin/sh.exe -c c:/mozilla-build/python/python.exe
h:/m/mozilla-central/build/pymake/make.py -f client.mk -s
 0:03.27 TEST-PASS | check-sync-dirs.py | h:\m\mozilla-central\js\src\config <=
h:\m\mozilla-central\config
 0:05.13 Build configuration changed. Regenerating backend.
 0:05.33 Traceback (most recent call last):
 0:05.33   File "./config.status", line 896, in <module>
 0:05.33     config_status(**args)
 0:05.33   File "h:\m\mozilla-central\build\ConfigStatus.py", line 87, in config
_status
 0:05.33     non_global_defines=non_global_defines, substs=substs)
 0:05.33   File "h:\m\mozilla-central\python\mozbuild\mozbuild\backend\configenv
ironment.py", line 144, in __init__
 0:05.33     log(self._log, logging.INFO, 'lossy_encoding',
 0:05.33 NameError: global name 'log' is not defined
 0:05.34 h:\m\mozilla-central\config\rules.mk:659:0: command 'cd . && h:/m/mozil
la-central/obj-i686-pc-mingw32/_virtualenv/Scripts/python.exe ./config.status' f
ailed, return code 1
 0:05.34 <Makefile>: Found error
 0:05.34 Error remaking makefiles (ignored)
 0:05.34 h:\m\mozilla-central\client.mk:372:0: command 'c:/mozilla-build/python/
python.exe h:/m/mozilla-central/build/pymake/pymake/../make.py -j4 -C obj-i686-p
c-mingw32' failed, return code 2
 0:05.34 h:\m\mozilla-central\client.mk:172:0: command 'c:/mozilla-build/python/
python.exe h:/m/mozilla-central/build/pymake/pymake/../make.py -f h:/m/mozilla-c
entral/client.mk realbuild' failed, return code 2
 0:05.55 911 compiler warnings present.
2
Here is the offending line:
https://mxr.mozilla.org/mozilla-central/source/python/mozbuild/mozbuild/backend/configenvironment.py#144

I think we should just remove this log because
- This warning has been abondand for a long time.
- This message spams the console on Japanese Windows (1000+ times repeated).
- This message will cause failure only on non-Western Windows, like this bug.
Assignee: nobody → VYV03354
Status: NEW → ASSIGNED
Attachment #793738 - Flags: review?(gps)
Attachment #793738 - Flags: review?(gps) → review+
https://hg.mozilla.org/mozilla-central/rev/e9a5f51a13bb
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.