907975 - Several telemetry histograms sent for checkForBackgroundUpdates and notify that should only be sent for notify

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[Robert Strong (they/them - no direct email)]

Patch coming up

Comment 1

[Robert Strong (they/them - no direct email)]

Attachment: patch rev1

Comment 2

[Brian R. Bondy [:bbondy]]

Comment on attachment 793749 [details] [diff] [review]
patch rev1

Review of attachment 793749 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/mozapps/update/nsUpdateService.js
@@ +2580,5 @@
>    _checkForBackgroundUpdates: function AUS__checkForBackgroundUpdates(isNotify) {
>      this._isNotify = isNotify;
> +    // From this point on the telemetry reported differentiate between a call to
> +    // notify and a call to checkForBackgroundUpdates so they are reported
> +    // separately.

nit: From this point on, the telemetry .... *differentiates* between

Comment 3

[Robert Strong (they/them - no direct email)]

Attachment: patch - nit addressed

Carrying forward r+

Comment 4

[Robert Strong (they/them - no direct email)]

Pushed to fx-team
https://hg.mozilla.org/integration/fx-team/rev/a0319f439c3e

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/a0319f439c3e