907979 - remove code duplication from MochitestServer and WebsocketServer in runtests.py

Status: RESOLVED DUPLICATE of bug 907770

(Testing :: Mochitest, defect)

Description

[Jeff Hammel]

https://bugzilla.mozilla.org/show_bug.cgi?id=746243#c33

MochitestServer and WebsocketServer have start methods with duplicate code:

148     self._process = self._automation.Process(cmd)
149     pid = self._process.pid
150     if pid < 0:
151       log.error("Error starting websocket server.")
152       sys.exit(2)
153     log.info("runtests.py | Websocket server pid: %d", pid)

This code should be consolidated.  This could be done through inheritence or other means

Comment 1

[Jaspreet Singh]

Attachment: duplicate1hg.patch

I have tested locally for some of the tests.
Please review

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Jaspreet, thanks for filing this patch, in general this is a good patch and does what is asked here.  For the last few weeks there has been work in bug 907770 which involves refactoring the code to start/stop/manage the servers.  I am going to mark this as a duplicate of that bug since we are at r+.