907996 - Contacts: Fix error callbacks

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Gregor Wagner [:gwagner]]

Attachment: errorcb.diff

Comment 1

[Reuben Morais [:reuben]]

Comment on attachment 793769 [details] [diff] [review]
errorcb.diff

Review of attachment 793769 [details] [diff] [review]:
-----------------------------------------------------------------

r=me. Let's see if some of those intermittent timeouts we've been seeing are actually hidden failures :)

::: dom/contacts/ContactManager.js
@@ +632,5 @@
>        case "Contact:Save:Return:OK":
>        case "Contacts:Clear:Return:OK":
>        case "Contact:Remove:Return:OK":
>          req = this.getRequest(msg.requestID);
>          if (req)

nit: Since you're touching nearby code, might as well add the missing braces here.

@@ +637,5 @@
>            Services.DOMRequest.fireSuccess(req.request, null);
>          break;
> +      case "Contacts:GetAll:Return:KO":
> +        req = this.getRequest(msg.requestID);
> +        let message = msg.errorMsg | "unknown error"

||, semicolon. Put the case body inside a block so |message| doesn't leak to the rest of the switch.

@@ +639,5 @@
> +      case "Contacts:GetAll:Return:KO":
> +        req = this.getRequest(msg.requestID);
> +        let message = msg.errorMsg | "unknown error"
> +        if (req)
> +          Services.DOMRequest.fireError(req.cursor, message);

nit: Braces.

@@ +648,5 @@
>        case "Contacts:Clear:Return:KO":
>        case "Contacts:GetRevision:Return:KO":
>        case "Contacts:Count:Return:KO":
>          req = this.getRequest(msg.requestID);
> +        message = msg.errorMsg | "unknown error"

||, semicolon. Put the case body inside a block and do |let message = …|.

@@ +653,2 @@
>          if (req)
> +          Services.DOMRequest.fireError(req.request, message);

nit: braces? It looks like your qparent is old, this code doesn't look like this anymore.

Comment 2

[Gregor Wagner [:gwagner]]

https://hg.mozilla.org/integration/b2g-inbound/rev/2b62136bbc85

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2b62136bbc85