Closed Bug 908003 Opened 8 years ago Closed 8 years ago

[responsive mode] Better precision during resizing

Categories

(DevTools :: Responsive Design Mode, enhancement)

x86_64
All
enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 26

People

(Reporter: andre42m, Assigned: paul)

Details

Attachments

(2 files)

Attached patch Proposed patch.Splinter Review
I propose a better way to resize the screen using key modifiers.
The attached patch adds the following options while resizing:
Ctrl: Fine precision, every 4px moved resizes 1px;
Shift: Rounded precision, the resize is rounded by 10px;

I did not use Alt because Xfwm uses it plus mouse drag to move a window.
I think this patch is useful because it's complicated to get to the desired screen size without using the 'resize to <width> <height>' command.
This is a genius idea! I'll look at this patch today.
Apparently, the dimensions in the menuitem are not correctly updated (still follow the mouse delta, not the page delta).
Attached patch patch.diffSplinter Review
Andre, I hope you won't mind. I re-wrote your patch with, I think, a little more straight forward approach. I also added some tooltips to make this feature discoverable and added some tests.

Tell me what you think.

(I love this!)
Attachment #797754 - Flags: feedback?(andreldm1989)
Comment on attachment 797754 [details] [diff] [review]
patch.diff

Review of attachment 797754 [details] [diff] [review]:
-----------------------------------------------------------------

Of course I don't mind, your implementation is way better :)
I've just tested on Windows and it works nicely.
Thanks!
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #797754 - Flags: feedback?(andreldm1989) → review?(mratcliffe)
Comment on attachment 797754 [details] [diff] [review]
patch.diff

Review of attachment 797754 [details] [diff] [review]:
-----------------------------------------------------------------

Looks beautiful!
Attachment #797754 - Flags: review?(mratcliffe) → review+
https://hg.mozilla.org/mozilla-central/rev/9cc1839ef1f2
Assignee: nobody → paul
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 26
Tooltip doesn't show for the vertical resizer. Is this purposeful?
Indeed it's a flaw.
Fixing it on bug 912743.
Thank you!
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.