908003 - [responsive mode] Better precision during resizing

Status: RESOLVED FIXED

(DevTools :: Responsive Design Mode, enhancement)

Description

[André Miranda]

Attachment: Proposed patch.

I propose a better way to resize the screen using key modifiers.
The attached patch adds the following options while resizing:
Ctrl: Fine precision, every 4px moved resizes 1px;
Shift: Rounded precision, the resize is rounded by 10px;

I did not use Alt because Xfwm uses it plus mouse drag to move a window.
I think this patch is useful because it's complicated to get to the desired screen size without using the 'resize to <width> <height>' command.

Comment 1

[Paul Rouget [:paul]]

This is a genius idea! I'll look at this patch today.

Comment 2

[Paul Rouget [:paul]]

Apparently, the dimensions in the menuitem are not correctly updated (still follow the mouse delta, not the page delta).

Comment 3

[Paul Rouget [:paul]]

Attachment: patch.diff

Andre, I hope you won't mind. I re-wrote your patch with, I think, a little more straight forward approach. I also added some tooltips to make this feature discoverable and added some tests.

Tell me what you think.

(I love this!)

Comment 4

[André Miranda]

Comment on attachment 797754 [details] [diff] [review]
patch.diff

Review of attachment 797754 [details] [diff] [review]:
-----------------------------------------------------------------

Of course I don't mind, your implementation is way better :)
I've just tested on Windows and it works nicely.
Thanks!

Comment 5

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Comment on attachment 797754 [details] [diff] [review]
patch.diff

Review of attachment 797754 [details] [diff] [review]:
-----------------------------------------------------------------

Looks beautiful!

Comment 6

[Paul Rouget [:paul]]

Thank you André!

https://hg.mozilla.org/integration/fx-team/rev/9cc1839ef1f2

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/9cc1839ef1f2

Comment 8

[cheesypoof]

Tooltip doesn't show for the vertical resizer. Is this purposeful?

Comment 9

[André Miranda]

Indeed it's a flaw.
Fixing it on bug 912743.
Thank you!