[responsive mode] Better precision during resizing

RESOLVED FIXED in Firefox 26

Status

--
enhancement
RESOLVED FIXED
6 years ago
8 months ago

People

(Reporter: andreldm1989, Assigned: paul)

Tracking

Trunk
Firefox 26
x86_64
All

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

6 years ago
Created attachment 793776 [details] [diff] [review]
Proposed patch.

I propose a better way to resize the screen using key modifiers.
The attached patch adds the following options while resizing:
Ctrl: Fine precision, every 4px moved resizes 1px;
Shift: Rounded precision, the resize is rounded by 10px;

I did not use Alt because Xfwm uses it plus mouse drag to move a window.
I think this patch is useful because it's complicated to get to the desired screen size without using the 'resize to <width> <height>' command.
(Assignee)

Comment 1

6 years ago
This is a genius idea! I'll look at this patch today.
(Assignee)

Comment 2

6 years ago
Apparently, the dimensions in the menuitem are not correctly updated (still follow the mouse delta, not the page delta).
(Assignee)

Comment 3

6 years ago
Created attachment 797754 [details] [diff] [review]
patch.diff

Andre, I hope you won't mind. I re-wrote your patch with, I think, a little more straight forward approach. I also added some tooltips to make this feature discoverable and added some tests.

Tell me what you think.

(I love this!)
Attachment #797754 - Flags: feedback?(andreldm1989)
(Reporter)

Comment 4

6 years ago
Comment on attachment 797754 [details] [diff] [review]
patch.diff

Review of attachment 797754 [details] [diff] [review]:
-----------------------------------------------------------------

Of course I don't mind, your implementation is way better :)
I've just tested on Windows and it works nicely.
Thanks!
(Assignee)

Updated

6 years ago
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
(Assignee)

Updated

6 years ago
Attachment #797754 - Flags: feedback?(andreldm1989) → review?(mratcliffe)
Comment on attachment 797754 [details] [diff] [review]
patch.diff

Review of attachment 797754 [details] [diff] [review]:
-----------------------------------------------------------------

Looks beautiful!
Attachment #797754 - Flags: review?(mratcliffe) → review+
https://hg.mozilla.org/mozilla-central/rev/9cc1839ef1f2
Assignee: nobody → paul
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 26

Comment 8

6 years ago
Tooltip doesn't show for the vertical resizer. Is this purposeful?
(Reporter)

Comment 9

6 years ago
Indeed it's a flaw.
Fixing it on bug 912743.
Thank you!

Updated

8 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.