908023 - [Buri][contacts]The content display abnormally after contact was imported from Hotmail

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Gaia::Contacts, defect, P1)

Description

[sync-1]

Mozilla build ID:20130806071254
 
 
 Created an attachment (id=495578)
 pic_The content display abnormally
 
 DEFECT DESCRIPTION:
 The content display abnormally after contact was imported from Hotmail
 
 REPRODUCING PROCEDURES:
 Pre:To have a Hotmail account with several contacts available to show/import 
 
 Step: 
 1. Open Contacts app->Tap on the settings icon (gear) in the top right
 corner->Tap on ‘outlook’under import contacts sub heading->The log in
 screen is shown->Introduce a valid user/password->Tap on sign in->select
  a contact(eg: ran zhang)->import
 2. click the contact just be imported->enter in contact details，the
 content of 'company' lost -->KO1
 3. the 'country' which was contained in adress lost-->KO2
 the tag of phone number display abnormally，which should show home tag not
 personal tag-->KO3
 4. the content of 'comments' lost-->KO4
 
 EXPECTED BEHAVIOUR:
 KO1:the content of 'company' should display mormally 
 KO2:the 'country' which was contained in adress should  show normally
 KO3:the tag of phone number display abnormally
 KO4:the content of 'comments' display normally
 
 ASSOCIATE SPECIFICATION:
 
 TEST PLAN REFERENCE:
 Free test
 
 TOOLS AND PLATFORMS USED:
 
 USER IMPACT:
 Medium
 
 REPRODUCING RATE:
 5/5
 For FT PR, Please list reference mobile's behavior:

Comment 1

[sync-1]

Clone from brother

Comment 2

[sync-1]

Attachment: pic_The content display abnormally

Comment 3

[sync-1]

Clone from brother

Comment 4

[sync-1]

Attachment: adb log

Comment 5

[sync-1]

Clone from brother

Comment 6

[sync-1]

Attachment: log

Comment 7

[buri.blff]

ko1, we find the data from hotmail servie dosen't include the company information.
ko2, we has resolve.
KO3: the tag of phone number display is same to the data form hotmail service;
KO4: the data from hotmail servie dosen't include 'comments';

so, the api give error informtion to app;
so, i want to konow:
 Does our api fot hotmail is right? or need other paprameters?

Comment 8

[Preeti Raghunath(:Preeti)]

David,

Please assign so we can check if this is even an issue.

Comment 9

[Andrew Overholt [:overholt]]

(In reply to buri.blff from comment #7)
> ko1, we find the data from hotmail servie dosen't include the company
> information.

So this is okay?

> ko2, we has resolve.

So this is fine now?

> KO3: the tag of phone number display is same to the data form hotmail
> service;

So things are good with this?

> KO4: the data from hotmail servie dosen't include 'comments';

So it's no problem?

These questions aside, this seems like a broken new 1.1 feature (Hotmail contacts import) so blocking and assigning to Jose.

Comment 10

[buri.blff]

(In reply to Andrew Overholt [:overholt] from comment #9)
> (In reply to buri.blff from comment #7)
> > ko1, we find the data from hotmail servie dosen't include the company
> > information.
> 
> So this is okay?
> 
> > ko2, we has resolve.
> 
> So this is fine now?
> 
> > KO3: the tag of phone number display is same to the data form hotmail
> > service;
> 
> So things are good with this?
> 
> > KO4: the data from hotmail servie dosen't include 'comments';
> 
> So it's no problem?
> 
> These questions aside, this seems like a broken new 1.1 feature (Hotmail
> contacts import) so blocking and assigning to Jose.



now, only  ko2 is ok;

ko1,ko3 and ko4 is caused for the wrong data from hotmail.
so, we need to check why the data from hotmail is wrong or if we use the api rightly??

Comment 11

[buri.blff]

is there any progress about checking the api?

Comment 12

[Preeti Raghunath(:Preeti)]

Buri,

Is this specific to hotmail alone? OR are we seeing it with other accounts too?

Comment 13

[buri.blff]

yes ,this is specific to hotmail alone.
import from outlook is ok.

Comment 14

[Jose Manuel Cantera]

Hi guys,

Could you share with me the account data you used for testing?

you can send it by private email

thanks

Comment 15

[Preeti Raghunath(:Preeti)]

Jose,

Did you get the requested data?

Any finding from your end?

Comment 16

[Jose Manuel Cantera]

I didn't get any data. Please could you resend it

thanks

Comment 17

[buri.blff]

this is the data from hotmail:


{
         "id": "contact.7d67f629000000000000000000000000", 
         "first_name": "ran", 
         "last_name": "Zhang", 
         "name": "ran Zhang", 
         "is_friend": false, 
         "is_favorite": false, 
         "user_id": null, 
         "email_hashes": [
            "3c117c1379a8c2358a27c33ae0a12471d6325b05649f1a53427628afb607ee26"
         ], 
         "updated_time": "2013-08-27T07:35:47+0000", 
         "birth_day": null, 
         "birth_month": null, 
         "emails": {
            "preferred": "\"[e-mail]\" <[e-mail]>", 
            "account": null, 
            "personal": "\"[e-mail]\" <[e-mail]>", 
            "business": null, 
            "other": null
         }, 
         "addresses": {
            "personal": {
               "street": null, 
               "street_2": null, 
               "city": null, 
               "state": null, 
               "postal_code": null, 
               "region": null
            }, 
            "business": {
               "street": "xinan", 
               "street_2": null, 
               "city": "wuxi", 
               "state": "China", 
               "postal_code": "222000", 
               "region": null
            }
         }, 
         "phones": {
            "personal": "0516 8599 017", 
            "business": null, 
            "mobile": "138 6701 7193"
         }
      }

there is no company information to us.

Comment 18

[Jose Manuel Cantera]

could you share by email the account details. otherwise I will not be able to reproduce.

Comment 19

[buri.blff]

account:[e-mail]
password:cds3424050024

Comment 20

[buri.blff]

Dear Jose:
we has give the hotmail account and password;

Comment 21

[buri.blff]

Dear Jose:
  Is there any progress?

Comment 22

[Jose Manuel Cantera]

hi,

Concerning the company name, it is a field we don't deal with it in the current implementation. I think it is an enhancement but not a bug. With respect to the comment field, the comment fields are not provided by the Live API.

The country name in your account is bad mapped to the state field. See 

http://msdn.microsoft.com/en-us/library/live/hh243648.aspx#user

The carrier info is something we cannot guess from the data web get from the API. 

In an essence, I believe there is nothing blocking in this bug, and IMHO it should not be leo+ .

Comment 23

[Preeti Raghunath(:Preeti)]

Moving to 1.3? per comment 22.

Comment 24

[buri.blff]

this pr is block pr;

the comment field "employer" is not ok for commpany??

Comment 25

[buri.blff]

i want to know why the data we get from hotmail is not consist to :

{
   "id": "8c8ce076ca27823f", 
   "name": "Roberto Tamburello", 
   "first_name": "Roberto", 
   "last_name": "Tamburello", 
   "link": "http://cid-8c8ce076ca27823f.profile.live.com/", 
   "birth_day": 20, 
   "birth_month": 4, 
   "birth_year": 2010, 
   "work": [
      {
         "employer": {
            "name": "Microsoft Corporation"
         }, 
         "position": {
            "name": "Software Development Engineer"
         }
      }
   ], 
   "emails": {
      "preferred": "[e-mail]",
      "account": "[e-mail]", 
      "personal": "[e-mail]", 
      "business": "[e-mail]",
      "other": "[e-mail]"
   },
   "addresses": {
      "personal": {
         "street": "123 Main St.", 
         "street_2": "Apt. A", 
         "city": "Redmond", 
         "state": "WA", 
         "postal_code": "12990", 
         "region": "United States"
      }, 
      "business": {
         "street": "456 Anywhere St.", 
         "street_2": "Suite 1", 
         "city": "Redmond", 
         "state": "WA", 
         "postal_code": "12399", 
         "region": "United States"
      }
   }, 
   "phones": {
      "personal": "[phone]", 
      "business": "[phone]", 
      "mobile": null
   }, 
   "locale": "en_US", 
   "updated_time": "2011-04-21T23:55:34+0000"
}



we don't get 
"work": [
      {
         "employer": {
            "name": "Microsoft Corporation"
         }, 
         "position": {
            "name": "Software Development Engineer"
         }
      }
   ],

Comment 26

[buri.blff]

if we can get 
"work": [
      {
         "employer": {
            "name": "Microsoft Corporation"
         }, 
         "position": {
            "name": "Software Development Engineer"
         }
      }
   ],

we can use the info "employer"

Comment 27

[buri.blff]

android can get the "company" info

Comment 28

[Jose Manuel Cantera]

oh yes, indeed. The decision to make here is if we implement this for v1.1, v1.2 or v1.3.

To be honest is a quite easy enhancement. So, I would let this decision to you guys.

Comment 29

[buri.blff]

(In reply to Jose M. Cantera from comment #28)
> oh yes, indeed. The decision to make here is if we implement this for v1.1,
> v1.2 or v1.3.
> 
> To be honest is a quite easy enhancement. So, I would let this decision to
> you guys.

Sorry, i don't know how to add the comment fields, hope your suggestion.

If you don't want to merge,  you can give me suggestion, i will change on our code, thanks.

Comment 30

[Jose Manuel Cantera]

I would prefer to do that in our branches. It will be ready by the end of today, tomorrow morning (Spain) at the latest.

Comment 31

[buri.blff]

thanks.

Comment 32

[Jose Manuel Cantera]

Attachment: 12395.html

Please try this patch and get back to me with the results.

Comment 33

[buri.blff]

Dear Jose:
   the patch is not ok, there still is no company info in company comment fields;

Comment 34

[buri.blff]

Dear Jose:
   we find the data from hotmail dose't have work info.

Comment 35

[buri.blff]

Dear Jose:
   we find the data from hotmail dosen't have work info. But the android import contact from hotmail, there is work info.

Comment 36

[buri.blff]

Dear Jose:
   we find the data from hotmail dosen't have work info. But the android import contact from hotmail, there is work info.

Comment 37

[Jose Manuel Cantera]

Comment on attachment 809181 [details]
12395.html

the proposed patch is not valid as the compny info is not the in the Contact Object but in the user object.

Comment 38

[Jose Manuel Cantera]

Hi guys,

Getting the company info or the Notes is not trivial as it is present on another object (user object). This means that we will need to do an additional query per Contact object, which will imply architectural changes in our Connector components. That IMHO should be postponed to v1.3. Sorry for any inconvenience but I thought it was easier but actually it is not. 

Definetely something for v1.3. 

thanks, best

Comment 39

[David Scravaglieri [:scravag]]

jmcf please renominate if you have bandwidth and if the architecture can be reviewed at this stage of 1.3 dev.

Comment 40

[David Scravaglieri [:scravag]]

minused per comment 39

Comment 41

[Jack Liu]

importing contacts from hotmail is still blocker for end user.

Comment 42

[Jason Smith [:jsmith]]

This is not a regression, so the blocking- decision above still stands. We can certainly look into fixing this though.

Comment 43

[Germán Toro del Valle (:gtorodelvalle)]

Deleting myself as the assignee since no currently working on it ;-)

Comment 44

[Noemí Freire (:noemi)]

Adding to backlog to be properly prioritized. Thanks!