Closed Bug 908051 Opened 6 years ago Closed 6 years ago

mach talos-test fails on Windows with AttributeError: 'module' object has no attribute 'uname'

Categories

(Testing :: Talos, defect)

Product:
Testing
Component:
Talos
Platform:
All
Windows 7
Type:
defect
Priority:
Not set

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla27

People

(Reporter: MattN, Assigned: jyeo)

References

Details

(Whiteboard: [mach])

Attachments

(1 file)

uname_fix.diff
1.16 KB, patch
gps
: review+
Details | Diff | Splinter Review 
AttributeError: 'module' object has no attribute 'uname'
from the line
    'title': os.uname()[1].lower().split('.')[0],

Python docs say os.uname is only available on "recent flavors of Unix". [1]

[1] http://docs.python.org/2/library/os.html#os.uname
Attached patch uname_fix.diff — — Splinter Review 
Using socket.gethostname() instead.
Assignee: nobody → jasonyeo88
Attachment #793849 - Flags: review?(gps)
Component: mach → Talos
Product: Core → Testing
Whiteboard: [mach]
Attachment #793849 - Flags: review?(gps) → review+
did this land?  if not, lets land this and close out the bug!
Not landed yet.
Keywords: checkin-needed
https://hg.mozilla.org/integration/fx-team/rev/039e8cb45a4f

Please make sure that future patches have all the needed commit information in them per the link below. Thanks!
https://developer.mozilla.org/en-US/docs/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F
Keywords: checkin-needed
Whiteboard: [mach] → [mach][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/039e8cb45a4f
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [mach][fixed-in-fx-team] → [mach]
Target Milestone: --- → mozilla27
You need to log in before you can comment on or make changes to this bug.