If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

mach talos-test fails on Windows with AttributeError: 'module' object has no attribute 'uname'

RESOLVED FIXED in mozilla27

Status

Testing
Talos
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: MattN, Assigned: jyeo)

Tracking

Trunk
mozilla27
All
Windows 7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [mach])

Attachments

(1 attachment)

AttributeError: 'module' object has no attribute 'uname'
from the line
    'title': os.uname()[1].lower().split('.')[0],

Python docs say os.uname is only available on "recent flavors of Unix". [1]

[1] http://docs.python.org/2/library/os.html#os.uname
(Assignee)

Comment 1

4 years ago
Created attachment 793849 [details] [diff] [review]
uname_fix.diff

Using socket.gethostname() instead.
Assignee: nobody → jasonyeo88
Attachment #793849 - Flags: review?(gps)

Updated

4 years ago
Component: mach → Talos
Product: Core → Testing
Whiteboard: [mach]

Updated

4 years ago
Attachment #793849 - Flags: review?(gps) → review+
did this land?  if not, lets land this and close out the bug!

Comment 3

4 years ago
Not landed yet.
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
https://hg.mozilla.org/integration/fx-team/rev/039e8cb45a4f

Please make sure that future patches have all the needed commit information in them per the link below. Thanks!
https://developer.mozilla.org/en-US/docs/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F
Keywords: checkin-needed
Whiteboard: [mach] → [mach][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/039e8cb45a4f
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Whiteboard: [mach][fixed-in-fx-team] → [mach]
Target Milestone: --- → mozilla27
You need to log in before you can comment on or make changes to this bug.