908051 - mach talos-test fails on Windows with AttributeError: 'module' object has no attribute 'uname'

Status: RESOLVED FIXED

Description

[Matthew N. [:MattN] (huge backlog; PM if requests are blocking you)]

AttributeError: 'module' object has no attribute 'uname'
from the line
    'title': os.uname()[1].lower().split('.')[0],

Python docs say os.uname is only available on "recent flavors of Unix". [1]

[1] http://docs.python.org/2/library/os.html#os.uname

Comment 1

[Jason Yeo[:jyeo]]

Created attachment 793849 [details] [diff] [review]
uname_fix.diff

Using socket.gethostname() instead.

Comment 2

[Joel Maher ( :jmaher) (UTC-5)]

did this land?  if not, lets land this and close out the bug!

Comment 3

[Jeff Hammel]

Not landed yet.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/039e8cb45a4f

Please make sure that future patches have all the needed commit information in them per the link below. Thanks!
https://developer.mozilla.org/en-US/docs/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/039e8cb45a4f