Error console causes Firefox Metro to hang for several seconds when containing several messages

VERIFIED FIXED in Firefox 30

Status

defect
P2
normal
VERIFIED FIXED
6 years ago
5 years ago

People

(Reporter: flod, Assigned: jimm)

Tracking

unspecified
Firefox 30
All
Windows 8.1
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: p=1 s=it-30c-29a-28b.1 r=ff30)

Attachments

(2 attachments)

Currently testing on Win 8 Professional 64bit with Asus UX32VD (no touch).

Start Firefox Metro cold and try to open Error Console (SHIFT+CTRL+J): it should be displayed quickly.

Open a complex page with errors/warning, e.g. http://www.pseudotecnico.org/blog/

Press SHIFT+CTRL+J: if I click around browser is not responding and most times closes itself, if I wait patiently after 30 seconds the console is displayed.

From now on, whatever page you visit, you'll have to wait the same time before accessing the Error console. If you empty the console everything goes back to normal.
OS: Windows 8 → Windows 8 Metro
Summary: Error console causes Firefox Metro to hang for several seconds when containing several messages → Defect - Error console causes Firefox Metro to hang for several seconds when containing several messages
Whiteboard: [preview-triage] feature=defect c=tbd u=tbd p=0
Blocks: metrov2defect&change
No longer blocks: metrov1backlog
:flod, the in browser console has many problems, and yes, cang hang the browser waiting for all the messages to arrive.

However, the devtools remote console will output everything that would be in that console, so in general I recommend you use that. https://wiki.mozilla.org/Firefox/Windows_8_Integration#Using_Devtools .Let me know on irc or email if you have trouble setting it up.
Whiteboard: [preview-triage] feature=defect c=tbd u=tbd p=0 → feature=defect c=tbd u=tbd p=0
No longer blocks: metrov2defect&change
Whiteboard: feature=defect c=tbd u=tbd p=0 → [v1?] feature=defect c=tbd u=tbd p=0
Summary: Defect - Error console causes Firefox Metro to hang for several seconds when containing several messages → Error console causes Firefox Metro to hang for several seconds when containing several messages
Whiteboard: [v1?] feature=defect c=tbd u=tbd p=0 → [v1?] [defect] p=0
Whiteboard: [v1?] [defect] p=0 → [defect] p=0
While doing some update testing I put together some fixes for this.
Assignee: nobody → jmathies
Whiteboard: [defect] p=0 → [defect] p=1
Status: NEW → ASSIGNED
Priority: -- → P2
QA Contact: jbecerra
Whiteboard: [defect] p=1 → p=1 s=it-30c-29a-28b.1 r=ff30
Posted patch fixesSplinter Review
The big perf problem here involved the code entries which were displayed by default. I've cropped those and hidden them until you click on an entry. Plus some other cleanup and a new "follow" feature that keeps the most recently added entry visible. Also I spread the radio buttons on horizontally to create more room for the console window.
Attachment #8373530 - Flags: review?(ally)
Posted patch copy fixesSplinter Review
This fixes line ending issues when copying a single line using the context menu, and adds a copy all button with formatted output.
Attachment #8374038 - Flags: review?(ally)
Comment on attachment 8373530 [details] [diff] [review]
fixes

Review of attachment 8373530 [details] [diff] [review]:
-----------------------------------------------------------------

Looks pretty good overall (and I can't wait to get my grubby hands on it!)

::: browser/metro/base/content/bindings/console.xml
@@ +31,5 @@
>                <xul:label class="label title" value="&consoleErrLine.label;"/>
>                <xul:label class="label title" xbl:inherits="value=line"/>
>              </xul:hbox>
>            </xul:hbox>
>            

I know it's not related to this patch and not your fault, but could you make this icky tab go away while we're here?

@@ +39,5 @@
>          </xul:vbox>
>        </xul:hbox>
>      </content>
>    </binding>
>      

this one too

::: browser/metro/base/content/browser.xul
@@ +588,5 @@
>                        oncommand="ConsolePanelView.evaluateTypein()"/>
>              </hbox>
>              <hbox align="center"
>                    pack="end">
> +              <checkbox id="follow-checkbox" label="&consoleFollowCheckbox.label;" checked="true"/>

I don't feel 'follow-checkbox' is a super descriptive name, but I can't think of a better one offhand. Can you?

::: browser/metro/base/content/console.js
@@ +30,5 @@
>      this._bundle = Strings.browser;
>  
>      this._count = 0;
>      this.limit = 250;
> +    this.fieldMaxLength = 140;

where did this number come from?

@@ +115,5 @@
>            this.clearConsole();
>        }
>        catch (ex2) {
>          // Give up and append the object itself as a string
> +        index = this.appendMessage(aObject);

:)

@@ +156,5 @@
>      else {
>        row.setAttribute("hideSource", "true");
>      }
> +    // hide code by default, otherwise initial item display will
> +    // hang the browser.

thank you for commenting.
Attachment #8373530 - Flags: review?(ally) → review+
Comment on attachment 8374038 [details] [diff] [review]
copy fixes

Review of attachment 8374038 [details] [diff] [review]:
-----------------------------------------------------------------

Want!

Ship it.
Attachment #8374038 - Flags: review?(ally) → review+
(In reply to :Ally Naaktgeboren from comment #5)
> >      this._count = 0;
> >      this.limit = 250;
> > +    this.fieldMaxLength = 140;
> 
> where did this number come from?

Totally arbitrary. Toolkit code doesn't the same thing.
(In reply to Jim Mathies [:jimm] from comment #7)
> (In reply to :Ally Naaktgeboren from comment #5)
> > >      this._count = 0;
> > >      this.limit = 250;
> > > +    this.fieldMaxLength = 140;
> > 
> > where did this number come from?
> 
> Totally arbitrary. Toolkit code doesn't the same thing.

*does
quick followup to remove a Util.dump statement that slipped in there - 

https://hg.mozilla.org/integration/fx-team/rev/cc7f2f58561f
Went through the following issue during IT-30C-29A-28B.1 testing, used the following build:
- http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014-02-18-03-02-02-mozilla-central/

I reproduced the original issue using an older build following the test cases from comment #0, also used the following websites:
- bloomberg.com (Reproduced)
- polygon.com (Reproduced)
- ufc.ca (Reproduced)
- espn.com (Reproduced)

- Ensured the original test case from comment #0 worked without any issues
- Ensured that you can load all of the above websites and then load the JS console without any issues
- Ensured that you can open the JS console while the website is loading without any issues
- Ensured that you can scroll through the JS console error log via touch/trackpad
- Ensured JS console doesn't take 20-30 seconds to load as stated in comment #0
- Ensured that you can have several tabs opened and still can access the JS console without any issues
- Ensured that pressing the "Back" button under the JS console correctly returns the user to the correct tab
- Ensured that all the radio button filters are working correctly
- Ensured that all of the above test cases worked with different variations of snapped view
Status: RESOLVED → VERIFIED
OS: Windows 8 Metro → Windows 8.1
You need to log in before you can comment on or make changes to this bug.