[B2G][Helix][Browser][chenhoulai]Editing a bookmark in the browser address, set it to null or wrong address,Save and then can not be edited or remove the address

NEW
Unassigned

Status

Firefox OS
Gaia::Browser
P2
normal
5 years ago
4 years ago

People

(Reporter: lecky, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: sprintready)

(Reporter)

Description

5 years ago
User Agent: Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 6.1; Trident/4.0; SLCC2; .NET CLR 2.0.50727; .NET CLR 3.5.30729; .NET CLR 3.0.30729; Media Center PC 6.0; .NET4.0C; .NET4.0E)

Steps to reproduce:

Editing a bookmark in the browser address, set it to null or wrong address


Actual results:

Save and then can not be edited or remove the address


Expected results:

Save and then can  be edited or remove the address

Updated

5 years ago
Whiteboard: DUPEME
(Reporter)

Updated

5 years ago
blocking-b2g: --- → hd?
(Reporter)

Updated

4 years ago
Severity: normal → blocker
Priority: -- → P2
(Reporter)

Comment 1

4 years ago
hi,jason,let me clarify the issue

Steps to reproduce:

Editing a bookmark in the browser address, set it to empty address or wrong address,eg:aaaaaa.com


Actual results:

The bookmark can be Saved,but then it becomes not be editable,not removable.

Expected results:

If such modification to bookmark is not allowed,saving operation should not be allowed.

If saving operation is performed,then the user should be allowed to edit it or remove it.
(Reporter)

Updated

4 years ago
Component: General → Gaia::Browser
(Reporter)

Comment 2

4 years ago
hi,jason 

in gaia\apps\browser\js\browser.js  

  saveBookmark: function browser_saveBookmark() {
    var url = this.bookmarkUrl.value;
    var title = this.bookmarkTitle.value;
    var previousUrl = this.bookmarkPreviousUrl.value;
      //here should return when url is null and remind the user
      if (url == '') {
        document.getElementById("tip_bookmark_url").style.visibility="visible";
          return;
      }
 }
Flags: needinfo?(dale)
(Reporter)

Comment 3

4 years ago
hi,wayne,

could you check this issue,can it be fixed on V1.1?
Cant find a dupe for this either, confirmed the bug exists though, definitely sprint ready
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: needinfo?(dale)
Whiteboard: DUPEME → sprintready
(Reporter)

Updated

4 years ago
Flags: needinfo?(wchang)
I am bumping this to koi?... its observed on other 1.1 devices as well.

User impact : the bookmarks with incorrect addresses are not editable or removable, basically permanently leaving a non-functional link and user sees this each time browser is launched.

However, considering users will mostly visit a site and then bookmark it rather than entering an address manually, I dont see this as a critical blocker for v1.1.
blocking-b2g: hd? → koi?
Flags: needinfo?(wchang)
Severity: blocker → normal
blocking-b2g: koi? → ---
(Reporter)

Updated

4 years ago
Flags: needinfo?(brg)
(Reporter)

Updated

4 years ago
Summary: [B2G][Helix][Browser][gaoshan]Editing a bookmark in the browser address, set it to null or wrong address,Save and then can not be edited or remove the address → [B2G][Helix][Browser][chenhoulai]Editing a bookmark in the browser address, set it to null or wrong address,Save and then can not be edited or remove the address
Flags: needinfo?(brg)
(Reporter)

Comment 6

4 years ago
hi Beatriz:
  Would you agree this issue not to fix on 1.1?
Flags: needinfo?(brg)
(In reply to lecky from comment #6)
> hi Beatriz:
>   Would you agree this issue not to fix on 1.1?
Agree with comment 5.
Flags: needinfo?(brg)
You need to log in before you can comment on or make changes to this bug.