908135 - B2G NetworkManager: Remove dhcp attribute in nsINetworkInterface

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Edgar Chen [:edgar]]

In nsINetworkInterface, there is a |dhcp| attribute [1], it is used for asking NetworkManager to help to send dhcp request when a interface is registered. But in current code base, no matter ril or wifi, |dhcp| is always set to false. And actually getting IP things should be handled in each interface, instead of in NetworkManager. So we should remove this attribute and related codes.

[1] http://mxr.mozilla.org/mozilla-central/source/dom/system/gonk/nsINetworkManager.idl#42

Comment 1

[Edgar Chen [:edgar]]

Attachment: Remove dhcp attribute in nsINetworkInterface, v1

Comment 2

[Edgar Chen [:edgar]]

Comment on attachment 793957 [details] [diff] [review]
Remove dhcp attribute in nsINetworkInterface, v1

I have tested this patch in unagi device, the below are test cases:
1. Mobile data connectivity
2. Wifi connectivity
3. Mobile data + usb tethering
4. Mobile data + wifi hotspot

Vicamo, Vincent, could you help to review this patch? Thanks

Comment 3

[Edgar Chen [:edgar]]

try server: https://tbpl.mozilla.org/?tree=Try&rev=48236dd48606

Comment 4

[Edgar Chen [:edgar]]

try server: https://tbpl.mozilla.org/?tree=Try&rev=efd7cc2a3b1c

Comment 5

[Edgar Chen [:edgar]]

Attachment: Remove dhcp attribute in nsINetworkInterface, v1, r=vyang, vchang

Add r=vyang, vchang after r+.

Comment 6

[Edgar Chen [:edgar]]

https://hg.mozilla.org/integration/b2g-inbound/rev/4aaef6eade15

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4aaef6eade15