Closed Bug 908179 Opened 6 years ago Closed 6 years ago

[l10n] About panel: XUL structure for channel description inconsistent with strings and localization notes

Categories

(Firefox for Metro Graveyard :: Flyouts, defect)

All
Windows 8.1
defect
Not set

Tracking

(Not tracked)

VERIFIED FIXED
Firefox 26

People

(Reporter: flod, Assigned: emtwo)

References

Details

(Keywords: l12y)

Attachments

(4 files)

String file
http://hg.mozilla.org/mozilla-central/file/11f66b4a00ed/browser/metro/locales/en-US/chrome/aboutPanel.dtd#l47

XUL file
http://hg.mozilla.org/mozilla-central/file/11f66b4a00ed/browser/metro/base/content/browser.xul#l425

The channel description is formed by 3 labels: "You are currently on the " + channel-name + " update channel. ".

It's the same structure used in Firefox
http://hg.mozilla.org/mozilla-central/file/89294cd501d9/browser/locales/en-US/chrome/browser/aboutDialog.dtd#l89

But then in the XUL file you create a completely different layout, forcing the sentence on two lines:
"You are currently on the " + channel-name
" update channel. "

I think this should just be a single sentence wrapping on two lines if necessary. With the current structure no real reason for a blank space at the beginning of the third label either.

This would solve all problems with wording different from en-US, like a first string very short or what currently happens with Italian (https://bug906329.bugzilla.mozilla.org/attachment.cgi?id=791694) where the sentence is translated as "Current channel update: " + channel_name + ".".
Does this look like what we want?

I added generic max-widths which I think also help a little bit with bug 900072.
Attachment #794859 - Flags: review?(mbrubeck)
p=1
Assignee: nobody → msamuel
Attached image About Flyout Screenshot
Comment on attachment 794859 [details] [diff] [review]
v1: Adjust text in about flyout for clearer localization

Review of attachment 794859 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/metro/theme/browser.css
@@ +1159,5 @@
>  
> +flyoutpanel description,
> +flyoutpanel label {
> +  max-width: 266px;
> +}

Would "max-width: 100%;" work here?  If so, please use that.

If not, please change "flyoutpanel" to ".flyout-narrow".

Also, please move these into theme/flyoutpanel.css.  Thanks!
Attachment #794859 - Flags: review?(mbrubeck) → review+
Excellent! It remains only to fix it:
Not very beautiful. It is necessary to make the indentation. And when you download the update is also beyond the edge of the screen.
(In reply to Kapranov from comment #6)
> Not very beautiful. It is necessary to make the indentation. 
Can you explain exactly what you mean?

> And when you download the update is also beyond the edge of the screen.
I confirm, but I think that's part of bug 906329.
(In reply to Francesco Lodolo [:flod] from comment #7)
> I confirm, but I think that's part of bug 906329.

Sorry, obviously meant bug 900072.
It is better to add spacing between rows
https://hg.mozilla.org/mozilla-central/rev/212facdbf920
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 26
Verified on 2013-08-26 build. Thanks :-)
Status: RESOLVED → VERIFIED
OS: Windows 8 Metro → Windows 8.1
You need to log in before you can comment on or make changes to this bug.