Closed Bug 908203 Opened 12 years ago Closed 12 years ago

Jstor pdf downloads are getting corrupt since version 23

Categories

(Firefox :: PDF Viewer, defect)

Product:
Firefox
Component:
PDF Viewer
Version:
23 Branch
Platform:
x86
All
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 26

People

(Reporter: raghavan8585, Unassigned)

References

Details

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_7_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/29.0.1547.57 Safari/537.36 Steps to reproduce: 1)Go to jstor.org, Register for an account if you don't have one. 2)Then go and add a url like http://www.jstor.org/stable/630731 to your shelf and access your link again. 3) Click on View Pdf link. Accept the terms and conditions if you have to. The pdf will open in the browser. Click on the download link and attempt to open or save it and open it in adobe acrobat. Actual results: The size is increased by 1.5 times the actual size and says, "There was an error opening this document. The file is damaged and could not be repaired". This does not happen in firefox version 22 and in other browsers. Expected results: The pdf should have opened normally.
Everyone I know has also been facing this problem after the firefox update. Restart in safe mode and using a new firefox profile did not fix the problem. Every pdf download using firefox version 23.0.1 at jstor.org site is corrupted and nearly doubled in size compared the normal download from any other browser or using firefox version 22 or below.
Sorry, I didn't fully understand the problem. I've tried to download a free journal and I've reproduced the problem. (http://www.jstor.org/stable/40066883) Using mozregression Last good nightly: 2013-08-11 First bad nightly: 2013-08-12 Pushlog: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=3d20597e0a07&tochange=87c1796bc46c
Component: Untriaged → General
Hi Tiziana, I'd really appreciate if I could get an update on this issue. Thanks, Raghavan
This works fine for me on Mac OSX 10.7.5 with the 09/25 Firefox 27a1 and Abode Reader 11.0.3. What versions of Firefox and Abode are you using to reproduce this bug?
Flags: needinfo?(raghavan8585)
Jstor has created a workaround to download the pdf straight away on Firefly 23 version and above instead of viewing the pdf on browser. More specifically, content-disposition has been changed from inline to attachment. Tiziana had reproduced the problem earlier when Jstor didn't have the workaround in place.
Flags: needinfo?(raghavan8585)
(In reply to Raghavan Parthasarathy from comment #6) > Firefly 23 version. but now it works with latest Nightly on Mac OSX 10.8.5 for me too.
Tiziana, Can you confirm that it anything changed between First bad nightly: 2013-08-12 and the latest Nightly ? Are you seeing that the "First bad nightly: 2013-08-12" is still reporting as bad ? I guess not, since "Jstor has created a workaround to download the pdf straight away on Firefly 23 version and above instead of viewing the pdf on browser. More specifically, content-disposition has been changed from inline to attachment. "
(In reply to Raghavan Parthasarathy from comment #8) > Can you confirm that it anything changed between First bad nightly: > 2013-08-12 and the latest Nightly ? > > Are you seeing that the "First bad nightly: 2013-08-12" is still reporting > as bad ? No, I cannot reproduce the issue on my previously declared bad nightly now.
The reason is in comment #6 and comment #8. I could have Jstor set up a URL without the workaround so that you can test again. Please let me know if that will work ?
Happened in FF 23, now FF 24. No need for a JSTOR workaround avoidance, just go to many of the University of Utah Admin pages on http://fbs.admin.utah.edu/forms-a/, such as http://fbs.admin.utah.edu/forms-a/#R and select "Requisition/General PO". Different machines/users/profiles result in the same PDF with FF added content at end.
In the utah links, I am able to view the pdf in the browser, the download link works fine and open well in adobe acrobat. But in the jstor links, until the workaround in place, I used to get, ""There was an error opening this document. The file is damaged and could not be repaired" and the pdf's sizes were bloated by nearly twice the size.
> Raghavan Parthasarathy 2013-09-29 22:01:13 PDT Yes, it appears even some local Firefox/OSX setups can save without the added content on the end, indicating it may not be a base FF issue, but that is not clear yet. The UofU PDFs have been consistent problems for us. > Masatoshi Kimura [:emk] 2013-09-29 22:53:11 PDT When using a non-FF the download/save/open-in-adobe-reader works fine. The file does not acquire extra NULLs at the end and it appears it is the extra data that causes Adobe Reader to throw up its arms, probably because it does not find the final index in the place it expects.
Changing component per comment 14.
Component: General → PDF Viewer
Using http://pubs.vmware.com/vsphere-55/topic/com.vmware.ICbase/PDF/ws9_esx55_vmci_sockets.pdf from bug 924168, I've found that the bug appeared between 2013-04-12-03-08-28-mozilla-central-firefox-23.0a1.en-US.linux-x86_64 2013-04-13-03-09-27-mozilla-central-firefox-23.0a1.en-US.linux-x86_64 https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=7b8ed29c6bc0&tochange=24a6b5ed51e3 disappeared between bug: 2013-09-12-03-02-01-mozilla-central-firefox-26.0a1.en-US.linux-x86_64 a4e9c9c9dbf9 WFM: 2013-09-13-03-02-01-mozilla-central-firefox-26.0a1.en-US.linux-x86_64 b9029b1de410 https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=a4e9c9c9dbf9&tochange=b9029b1de410 The latter includes a PDF.js update bug 914603 comment #0, which refers to https://github.com/mozilla/pdf.js/pull/3634 “Firefox: Corrupt downloads ("padded" downloads) when there is no content length”, which was also reported at https://github.com/mozilla/pdf.js/issues/3627 So I assume that was the bug, and mark it fixed.
Status: UNCONFIRMED → RESOLVED
Closed: 12 years ago
OS: Mac OS X → All
Resolution: --- → FIXED
See Also: → https://github.com/mozilla/pdf.js/issues/3627
Target Milestone: --- → Firefox 26
I wouldn't mark it as fixed as yet. Since we know for certain that Last good nightly: 2013-08-11 First bad nightly: 2013-08-12 were we able to identify the bug got added between 11th and 12th ? "appeared between 2013-04-12-03-08-28-mozilla-central-firefox-23.0a1.en-US.linux-x86_64 2013-04-13-03-09-27-mozilla-central-firefox-23.0a1.en-US.linux-x86_64 https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=7b8ed29c6bc0&tochange=24a6b5ed51e3" Seems like the date range is big to identify it as this bug. "The latter includes a PDF.js update bug 914603 comment #0, which refers to https://github.com/mozilla/pdf.js/pull/3634 “Firefox: Corrupt downloads ("padded" downloads) when there is no content length”, which was also reported at https://github.com/mozilla/pdf.js/issues/3627" The Jstor pdfs do in fact report the content-length.
Status: RESOLVED → UNCONFIRMED
Resolution: FIXED → ---
Can you test with Firefox v26 and confirm it's fixed?
Flags: needinfo?(raghavan8585)
Can't find FF v26, but just tested with v27 nightly (27.0a1 2013-10-14) and it works fine now. Thanks!
Status: UNCONFIRMED → RESOLVED
Closed: 12 years ago → 12 years ago
Resolution: --- → FIXED
Was able to confirm that it is now working fine. Thanks !
Flags: needinfo?(raghavan8585)
You need to log in before you can comment on or make changes to this bug.