908229 - Make framecounter invalidate widget

Status: RESOLVED DUPLICATE of bug 907286

(Core :: Graphics, defect)

Description

[Mike Conley (:mconley) (:⚙️)]

Attachment: Patch v1

Comment 1

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 794059 [details] [diff] [review]
Patch v1

Review of attachment 794059 [details] [diff] [review]:
-----------------------------------------------------------------

I think the view manager might be the wrong place for this place. It feels like it belongs in widget. Are you sure this doesn't impact painting at all?

::: view/src/nsViewManager.cpp
@@ +439,5 @@
> +
> +  // If we draw the frame counter we need to make sure we invalidate the area
> +  // for it to make it on screen
> +  if (gfxPlatform::DrawFrameCounter()) {
> +    r = r.Or(r, nsRect(0, 0, (16 * 3 + 10) * 60, 10 * 60));

You should get the FrameCounter rect from gfxPlatform() and try to make the frame counter size calculation obvious to the users.