908276 - Attach the EGL image to the texture in SwapTexturesImpl()

Status: RESOLVED DUPLICATE of bug 912134

(Core :: Graphics, defect)

Description

[Jeff Muizelaar [:jrmuizel]]

This will let us avoid holding the genlock on buffers after we've swapped out the old image.

Comment 1

[Jeff Muizelaar [:jrmuizel]]

Attachment: Prototype of this approach

Comment 2

[Sotaro Ikeda [:sotaro]]

GrallocTextureSourceOGL in attachment 794681 [details] [diff] [review] is leaking EGLImage. During a video playback, following log was outputted and video playback was almost stopped. I temporarily added a code to remove the EGLImage just after bind to gralloc buffer like b2g19, it fixed the leaking problem.

---------------------------

08-24 14:05:24.279   144   269 W Adreno200-GSL: <gsl_ldd_control:225>: ioctl code 0xc01c0915 (IOCTL_KGSL_MAP_USER_MEM) failed: errno 12 Out of memory
08-24 14:05:24.279   144   269 W Adreno200-EGLSUB: <CreateImage:1236>: fail gsl_memory_map.
08-24 14:05:24.279   144   269 W Adreno200-EGL: <qeglDrvAPI_eglCreateImageKHR:4504>: EGL_BAD_PARAMETER


n.b. I confirmed it by disabling HwComposer. If HwComposer is enable, video playback is not smooth. It seems related to Bug 908276.

Comment 3

[Sotaro Ikeda [:sotaro]]

Sorry, comment #2 is for Bug 907745.

Comment 4

[Sotaro Ikeda [:sotaro]]

Need update the patch depend on Bug 907745.

Comment 5

[Sotaro Ikeda [:sotaro]]

Bug 909851 try to fix the same problem by the way as in b2g18.

Comment 6

[Sotaro Ikeda [:sotaro]]

I tested attachment 794124 [details] [diff] [review] on master hamachi. performance becomes very bad and rendering UI sometimes have a fleck. Something seems bad.