908294 - More fixes for ExclusiveContext zones with TI enabled

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Brian Hackett [Laid off!]]

Attachment: patch

Bug 906060 missed some spots here.  This also fixes a place where lazy parsing was needlessly disabled when parsing scripts off thread.

Comment 1

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 794141 [details] [diff] [review]
patch

Review of attachment 794141 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jscntxt.h
@@ +263,5 @@
>      JSAtomState &names() { return runtime_->atomState; }
>      StaticStrings &staticStrings() { return runtime_->staticStrings; }
>      PropertyName *emptyString() { return runtime_->emptyString; }
>      FreeOp *defaultFreeOp() { return runtime_->defaultFreeOp(); }
> +    bool useHelperThreads() { return runtime_->useHelperThreads(); }

This is unused, but maybe you want it for later?

::: js/src/jsinfer.cpp
@@ +6129,5 @@
>  
>  TypeObject *
> +ExclusiveContext::getLazyType(Class *clasp, TaggedProto proto)
> +{
> +    JS_ASSERT_IF(proto.isObject(), compartment() == proto.toObject()->compartment());

Can you assert that we're not in the atoms compartment? Or, if we are, that we have a JSContext.

Comment 2

[Brian Hackett [Laid off!]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ed4429af6905

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ed4429af6905