908340 - mach xpcshell-test shouldn't print test start lines

Status: RESOLVED FIXED

(Testing :: XPCShell Harness, defect)

Description

[Gregory Szorc [:gps]]

I think it is next to worthless for |mach xpcshell-test| to print the test start notification, especially when tests are executed concurrently.

In my ideal world, we'd have a progress bar and the only output would be from failing tests. I'll settle for simply killing the test start notification.

Chris: Can you tackle this quickly now that structured logging has landed?

Comment 1

[Chris Manchester (limited bugmail, email directly)]

Yes. I'll take a look this afternoon.

Comment 2

[Chris Manchester (limited bugmail, email directly)]

Attachment: Omit test start messages from mach xpcshell output;

Unfortunately the "test start" message is output from Python, and my patch in
bug 890687 did not entail converting the Python logger to structured output,
so we're still working with strings here (I can look at converting XPCShell's
Python logger as a follow up; it might not take much).

So this is a little weird (what about other strings that might end with
"running test ..."?), but is effective for routine output.

Comment 3

[Gregory Szorc [:gps]]

Comment on attachment 794402 [details] [diff] [review]
Omit test start messages from mach xpcshell output;

A bit hacky, but sure.

Comment 4

[Gregory Szorc [:gps]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a970626be5c9

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a970626be5c9