Closed Bug 908347 Opened 8 years ago Closed 8 years ago

rm a bit more gunk related to the old parser

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla26

People

(Reporter: tbsaunde, Assigned: tbsaunde)

Details

Attachments

(19 files)

3.61 KB, patch
mrbkap
: review+
Details | Diff | Splinter Review
1.07 KB, patch
mrbkap
: review+
Details | Diff | Splinter Review
7.46 KB, patch
mrbkap
: review+
Details | Diff | Splinter Review
2.62 KB, patch
mrbkap
: review+
Details | Diff | Splinter Review
3.92 KB, patch
mrbkap
: review+
Details | Diff | Splinter Review
2.28 KB, patch
mrbkap
: review+
Details | Diff | Splinter Review
4.23 KB, patch
mrbkap
: review+
Details | Diff | Splinter Review
11.68 KB, patch
mrbkap
: review+
Details | Diff | Splinter Review
11.71 KB, patch
mrbkap
: review+
Details | Diff | Splinter Review
4.55 KB, patch
mrbkap
: review+
Details | Diff | Splinter Review
2.30 KB, patch
mrbkap
: review+
Details | Diff | Splinter Review
5.11 KB, patch
mrbkap
: review+
Details | Diff | Splinter Review
2.07 KB, patch
mrbkap
: review+
Details | Diff | Splinter Review
5.21 KB, patch
mrbkap
: review+
Details | Diff | Splinter Review
7.51 KB, patch
mrbkap
: review+
Details | Diff | Splinter Review
11.95 KB, patch
mrbkap
: review+
Details | Diff | Splinter Review
1.47 KB, patch
mrbkap
: review+
Details | Diff | Splinter Review
12.92 KB, patch
mrbkap
: review+
Details | Diff | Splinter Review
4.51 KB, patch
mrbkap
: review+
Details | Diff | Splinter Review
No description provided.
Attachment #794191 - Flags: review?(mrbkap)
Attachment #794192 - Flags: review?(mrbkap)
the first thing it does is to return if
nsIParserNode.GetAttributeCount() returned 0 which the one impl always
does, so its all dead code we can remove.
Attachment #794193 - Flags: review?(mrbkap)
Attachment #794196 - Flags: review?(mrbkap)
Attachment #794199 - Flags: review?(mrbkap)
Attachment #794200 - Flags: review?(mrbkap)
Attachment #794201 - Flags: review?(mrbkap)
Attachment #794204 - Flags: review?(mrbkap)
Attachment #794205 - Flags: review?(mrbkap)
Attached patch remove AddLeaf()Splinter Review
Attachment #794209 - Flags: review?(mrbkap)
It hardly seems useful to have debug logging for creating about:blank
Attachment #794210 - Flags: review?(mrbkap)
also remove IsMoonalithicContainer() since its not needed anymore.
Attachment #794212 - Flags: review?(mrbkap)
Attachment #794191 - Flags: review?(mrbkap) → review+
Attachment #794192 - Flags: review?(mrbkap) → review+
Attachment #794193 - Flags: review?(mrbkap) → review+
Attachment #794194 - Flags: review?(mrbkap) → review+
Attachment #794195 - Flags: review?(mrbkap) → review+
Attachment #794196 - Flags: review?(mrbkap) → review+
Attachment #794197 - Flags: review?(mrbkap) → review+
Comment on attachment 794198 [details] [diff] [review]
rm the bits of nsIHTMLContentSink nobody calls

Review of attachment 794198 [details] [diff] [review]:
-----------------------------------------------------------------

::: parser/htmlparser/public/nsIHTMLContentSink.h
@@ +63,2 @@
>   */
>  class nsIHTMLContentSink : public nsIContentSink 

You should bump the IID for nsIHTMLContentSink.
Attachment #794198 - Flags: review?(mrbkap) → review+
Attachment #794199 - Flags: review?(mrbkap) → review+
Attachment #794200 - Flags: review?(mrbkap) → review+
Comment on attachment 794201 [details] [diff] [review]
remove nsIHTMLCOntentSink::IsEnabled

Review of attachment 794201 [details] [diff] [review]:
-----------------------------------------------------------------

::: parser/htmlparser/public/nsIHTMLContentSink.h
@@ +61,3 @@
>   * Do NOT implement!
>   */
>  class nsIHTMLContentSink : public nsIContentSink 

Might as well bump the IID here as well.
Attachment #794201 - Flags: review?(mrbkap) → review+
Comment on attachment 794202 [details] [diff] [review]
make Open / Close Container() take an enum with only html and body elements

Review of attachment 794202 [details] [diff] [review]:
-----------------------------------------------------------------

::: parser/htmlparser/public/nsIHTMLContentSink.h
@@ +65,5 @@
>  public:
>  
>    NS_DECLARE_STATIC_IID_ACCESSOR(NS_IHTML_CONTENT_SINK_IID)
>  
> +    enum ElementType { eHTML, eBody };

Nit: indent in this file is 2 space instead of 4.

@@ +80,5 @@
>     *  container tag has been consumed and needs to be closed.
>     *
>     * @param  aTag - The tag to be closed.
>     */     
> +  NS_IMETHOD CloseContainer(const ElementType aTag) = 0;

Nuke the const?
Attachment #794202 - Flags: review?(mrbkap) → review+
Attachment #794204 - Flags: review?(mrbkap) → review+
Comment on attachment 794205 [details] [diff] [review]
rm nsIDebugDumpContent

Review of attachment 794205 [details] [diff] [review]:
-----------------------------------------------------------------

::: parser/htmlparser/src/nsParser.cpp
@@ -215,5 @@
>  void
>  nsParser::Cleanup()
>  {
>  #ifdef DEBUG
> -  if (gDumpContent) {

Please remove the rest of the uses (and the declaration) of gDumpContent.
Attachment #794205 - Flags: review?(mrbkap) → review+
Attachment #794206 - Flags: review?(mrbkap) → review+
Comment on attachment 794208 [details] [diff] [review]
remove text handling from html content sink

Review of attachment 794208 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/html/document/src/nsHTMLContentSink.cpp
@@ +654,4 @@
>  }
>  
>  /**
>   * Add textual content to the current running text buffer. If the text buffer

Please remove this comment as well.
Attachment #794208 - Flags: review?(mrbkap) → review+
Attachment #794209 - Flags: review?(mrbkap) → review+
Attachment #794210 - Flags: review?(mrbkap) → review+
Comment on attachment 794212 [details] [diff] [review]
rename CloseContainer() to CloseBody()

This is great! Thanks for doing it!
Attachment #794212 - Flags: review?(mrbkap) → review+
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.