backport attribution code to butter tree

RESOLVED WONTFIX

Status

RESOLVED WONTFIX
5 years ago
5 years ago

People

(Reporter: tracey, Assigned: tracey)

Tracking

Details

(Assignee)

Description

5 years ago
I believe most of the attribution/credits awesomeness from this tree can be ported to butter with just a few changes.


Add these 2 files to butter (not there now):
?? public/resources/icons/flickr-black.png
?? public/src/layouts/attribution.html

Copy this file to butter
public/css/embed.less    # needs some verification/checking that additional rule changes are OK or cherry pick instead

Update this file:
public/src/editor/media-gallery-editor.js 
per this patch:
https://github.com/mozilla/popcorn.webmaker.org/commit/28f7847b08fd0273aa279e9ff4070558a8c42179 


Copy this file to butter:
public/src/embed.js


There's some additional changes to my butter tree, but it has the changes above and shows it working pretty nicely!  8-)

http://popcorn.archive.org/templates/basic/
http://popcorn.archive.org/v/l.html
Thanks for this, Tracey.  I've CC'ed Matt and Scott, our Popcorn Maker leads, who can help shepherd this stuff into the tree.
Assignee: nobody → tracey
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true

Comment 2

5 years ago
Being unaware of the current protocol—

I believe the endgame is for http://popcorn.webmaker.org to properly parse and attribute media from Archive.org. Particularly the TV Archive.

Brett is supportive of this in the conversations we've had.

Why do we need to backport to Butter? Wouldn't it be easier to work on the canonical repo?

Cheers!
Ben
The canonical (mozilla/popcorn.webmaker.org) repo unfortunately is not very friendly to people to use for themselves. When we were working on the new webmaker.org we were fully aware of the fact that we would need to add a lot of things that were specific to webmaker.org's needs and wouldn't be useful at all to people who tried to use Popcorn Maker for themselves for various use cases.

1) We force S3 usage for saving projects and image uploading. If you don't have S3 credentials, it won't function.
2) MakeAPI. While obviously the idea of more people sending their projects to the MakeAPI is part of the overall end goal, there is no way to turn it off.
3) Webmaker accounts. You are required to have a webmaker account to save projects.

I think being able to distinguish Archive video's in attribution is a good idea, but people like Archive probably don't want to use the canonical repo for their work which is why we need to backport the feature to mozilla/butter.

Comment 4

5 years ago
Thanks for explaining. But in this case, we are actually trying to implement this functionality on the actual https://popcorn.webmaker.org, Mozilla installation.

For #1, we can always get Tracey some credentials to help with the development process. Should I ask JP?

Anyway, I would recommend closing this bug and focus on landing this on popcorn.webmaker.org—does that make sense to you guys? (Not sure, but want to make sure everyone's in the same loop).
If the goal is to have it on Webmakers PM install as well then that's cool. We should file a new bug and it can be assigned to me.

We will keep this one open however so that we can still back port this to the old butter repo.

As far as getting Tracey S3 creds, I don't know what the process is behind that. I would speak with some combo of JP and Jbuck. AddiNg Jbuck as a CC.

Comment 6

5 years ago
Amazon S3 does have a free tier of service available for a year when you sign up for AWS. Another option would be to run FakeS3 locally. Running the free tier is probably the easiest though!
(Assignee)

Comment 7

5 years ago
we have an S3 implementation at archive.org (totally free ;-) so we could use that.

I'm with Ben -- if possible, we'd ideally like this available in the popcorn.webmaker.org canonical site! 8-)

I could try to get the head of it running at popcorn.archive.org and hook in our S3 interface (sounds like that's required) and could confirm we'd have the attribution stuff working?

(Might have one minor request to allow a raw media from a parsed url (eg: our full "details" page auto parsing to a "raw" .mp4) to "map" in the Credits to the "details" page and not the raw .mp4, as a link, but I could see..)

Updated

5 years ago
Depends on: 913877
We are moving towards making our repo at mozilla/popcorn.webmaker.org forkable like our old mozilla/butter was for everyone. For that reason I'm going to won't fix this :)
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → WONTFIX
(Assignee)

Comment 9

5 years ago
makes sense, thanks, matt!
You need to log in before you can comment on or make changes to this bug.