Closed
Bug 908453
Opened 11 years ago
Closed 11 years ago
[e10s] Focusing on content area doesn't work on OS X
Categories
(Core :: XUL, defect)
Tracking
()
RESOLVED
FIXED
mozilla26
People
(Reporter: dvander, Assigned: dvander)
References
Details
Attachments
(1 file, 1 obsolete file)
|
1008 bytes,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
In nsXULElement.cpp, there's an OS X specific check that disables focusing on non-list elements. This is fine in same-process builds. On multi-process, it prevents the content area from grabbing focus, since the UI process can't see past the <browser> element. I'm not sure if this is the right fix, but just excluding <browser> elements from this check seems to fix the issue.
|
Assignee | |
Updated•11 years ago
|
Attachment #794280 -
Flags: review?(bugs)
|
|
Assignee | |
Comment 1•11 years ago
|
||
Slightly better fix
Attachment #794280 -
Attachment is obsolete: true
Attachment #794280 -
Flags: review?(bugs)
Attachment #794336 -
Flags: review?(bugs)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 794336 [details] [diff] [review] fix-focus.patch Fix the comment too.
Attachment #794336 -
Flags: review?(bugs) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/6b2ac23b18f7
|
||
Comment 4•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/6b2ac23b18f7
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in
before you can comment on or make changes to this bug.
Description
•