90849 - [CT] Classic smiley menu dropdown icon is disgusting

Status: VERIFIED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Blake Ross]

The Classic versions of smile_disabled.gif and smile_active.gif are not
acceptable icons for a theme that ships with a professional product.  They share
an unusual all-purple background and are an eyesore compared to all the other
toolbar icons in message compose and NIM (which are done right).  They should be
fixed, or this menu will be hidden on Classic.

Comment 1

[Blake Ross]

Attachment: screenshot of disabled toolbar icons (one of these is unlike the others)

Comment 2

[Blake Ross]

Plus smile_hover.gif has a hardcoded gray background (oops, Classic inherits
system colors), and smile.gif has a bunch of missing pixels.  Score! I knew all
four could have problems somehow.

Thankfully, I've fixed most of the problems.  We don't need special images for
hover or active, and I've fixed smile.gif.  But I still need a proper disabled
image.

Comment 3

[John Dobbins]

Attachment: smile_disabled.gif

Comment 4

[John Dobbins]

While I was looking at the classic theme bugs I noticed that the ugly disabled
image is covered under bug 77238

Comment 5

[Blake Ross]

Thanks, but the image should have the same gray dithering effect as the others.

Comment 6

[Anatoliy Averbukh]

Blake,

Gail White can probably able to help with that (she did smliey icons).
Gail, could you please help?

Comment 7

[gail]

Applying the same 'dithered' effect to the smiley that the other disabled icons 
have causes some weird effects where it no longer looks like a smiley. 
Following is a greyed out version instead which should suffice.

Comment 8

[gail]

Attachment: Smiley - disabled state

Comment 9

[Asa Dotzler [:asa]]

The every other pixel mask works just fine.  Depending on where the mask is
applied the smiley either looks pretty sad or a tad bit evil.  I'll tweak the
disabled mask a little bit to try to get the smiley looking a little happier and
attach the results.  It is my opinion that we should not take a "just grayed
out" version for disabled because this sticks out like a sore thumb on the toolbar.

Comment 10

[gail]

Attachment: smiley with alternating transparent pixels

Comment 11

[gail]

The attachment above is the normal smiley with the alternating transparent
pixels.  I have tried tweaking this and it just looks bad no matter what.
 

Comment 12

[Blake Ross]

Attachment: first shot at disabled smiley

Comment 13

[Asa Dotzler [:asa]]

oops, that was me (Asa) not blake. I've taken a slightly different path and gone
with remove color and every other pixel. It still looks a little unhappy to me
so I'll treak some more, maybe a muted yellow, something half way between yellow
and gray...

Comment 14

[Joe Hewitt (gone)]

sr=hewitt on the last icon

Comment 15

[Blake Ross]

Fix checked in.

Comment 16

[sairuh (rarely reading bugmail)]

vrfy fixed in html message compose and IM compose windows: both active and
disabled smiley menu dropdown icons look fine.

linux, 2001.08.15.14-comm
winnt, 2001.08.15.06-comm
mac OS 9.1 [emul on X], 2001.08.15.08-comm