908592 - [Keyboard] Improve symbol panel layout of Pinyin IME

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Comment 1

[Luke Chang [:lchang] (inactive)]

As Bug 900907 mentioned, the current layout of symbol panels do not fit the Simplified Chinese user's requirement. We will make a minimal layout change to enhance the user experience.

Comment 2

[Jing Zhang]

Attachment: revised-spec-of-symbol-panel-for-Simplified-Chinese.png

Notes:
中/英 symbols do not completely correspond to full/half-width symbols. Actually, most of symbols in both 中/英 symbol panels are half-width, except for ， 。 ？ ！ ： ； …… ～ （ ） “ ” 、 __ 《 》 【 】 ＊ · in 中文 symbol panels

Comment 3

[Luke Chang [:lchang] (inactive)]

Hi Neo,

I would like to know if you have any feedback about this spec.
Thanks.

Comment 4

[Neo Hsieh [:neo]]

Hi Luke, 
It's OK for me. The most important is to fit local users' experience. Thanks.

Comment 5

[Luke Chang [:lchang] (inactive)]

Attachment: work in process

Hi Pin, Xulei and Jing,

This is a WIP version. Could you please help me check if the characters (unicode / half or full width) of every symbols are all correct?

In addition, I have no idea which symbol is usually used in space key so I chose "⎵" in this version. Feel free to tell me if it is incorrect.

Thanks.

Comment 6

[Yuan Xulei [:yxl] (Leave from May 18)]

@Luke, after confirmed with Jing, only the "…" character does not matching the design. For the Chinese mode(中mode), it should output "……"(two consecutive "…" characters); while for the english mode(英mode), it should output "…"(one "…" chracter). 

Other parts are all correct.

Comment 7

[Pin Zhang [:pzhang] (inactive)]

Attachment: Screenshot

Hi Luke, the space character doesn't look good on the Unagi, please check this.

Comment 8

[Luke Chang [:lchang] (inactive)]

@Xulei, Thanks for your feedback. I'll fix it.

@Pin, I'm looking for another character but can't find a suitable one. Maybe we need an image for that.

BTW, I have two additional questions:

1. Should I remember last used page (1/1 or 1/2) when I click "中/英" button? (or default to 1st page.)
2. Since there is no layout else put a symbol on space key, should we put "⎵" on space key only in pinyin IME?

Comment 9

[Jing Zhang]

(In reply to Luke Chang [:lchang] from comment #8)
> @Xulei, Thanks for your feedback. I'll fix it.
> 
> @Pin, I'm looking for another character but can't find a suitable one. Maybe
> we need an image for that.
> 
> BTW, I have two additional questions:
> 
> 1. Should I remember last used page (1/1 or 1/2) when I click "中/英" button?
> (or default to 1st page.)
Yes, it's better to remember the page index when switching between "中/英"

> 2. Since there is no layout else put a symbol on space key, should we put
> "⎵" on space key only in pinyin IME?
So, let's put "空格"/"Space" on the space key for "中"/"英" symbol panel

Comment 10

[Jing Zhang]

(In reply to Jing Zhang from comment #9)
> (In reply to Luke Chang [:lchang] from comment #8)
> > @Xulei, Thanks for your feedback. I'll fix it.
> > 
> > @Pin, I'm looking for another character but can't find a suitable one. Maybe
> > we need an image for that.
> > 
> > BTW, I have two additional questions:
> > 
> > 1. Should I remember last used page (1/1 or 1/2) when I click "中/英" button?
> > (or default to 1st page.)
> Yes, it's better to remember the page index when switching between "中/英"
> 
> > 2. Since there is no layout else put a symbol on space key, should we put
> > "⎵" on space key only in pinyin IME?
> So, let's put "空格"/"Space" on the space key for "中"/"英" symbol panel
Sorry, using "空格" for both "中"/"英" symbol panel makes more sense in Simplified Chinese Input~

Comment 11

[Luke Chang [:lchang] (inactive)]

Attachment: Pull Request

Hi Jing, 
Ok, I've modified it. Thanks.

Hi Xulei and Rudy,
I've sent a pull request.
Could you please check if it fits user's need. Thanks.

Comment 12

[Yuan Xulei [:yxl] (Leave from May 18)]

@Jing, please make clarification about the following cases:

1. Switching between "中/英" should keep the symbol layout on the same page, or the last page?
More specifically, if user switches from page 2 of "中“ to "英", should he goes to page 2 of "英" or the last page he visits, which may be page 1 of "英".

2. If user switches to symbol layout from Pinyin layout, should the IME resets to first page of "中" or shows the last page user visits, which may be page 1 of "英", or page 2 of "中"?

3. Will "空格“ be shown on the space bar of all Pinyin IME layouts, or only on the symbol layouts?

Comment 13

[Yuan Xulei [:yxl] (Leave from May 18)]

Comment on attachment 802160 [details]
Pull Request

Luke, I made a rough review of your pull request. Some issues need to be fixed. Please refer to the comments of the pull request.

And I need Jing's information to perform further review.

Comment 14

[Jing Zhang]

(In reply to Yuan Xulei [:yxl] from comment #12)
> @Jing, please make clarification about the following cases:
> 
> 1. Switching between "中/英" should keep the symbol layout on the same page,
> or the last page?
> More specifically, if user switches from page 2 of "中“ to "英", should he
> goes to page 2 of "英" or the last page he visits, which may be page 1 of "英".
Keep consistent INDEX when switching between "中"&"英". Example, "中-1"=>"英-1"=>"中-1"; "中-1"=>"英-1"->"英-2"=>"中-2". 

> 
> 2. If user switches to symbol layout from Pinyin layout, should the IME
> resets to first page of "中" or shows the last page user visits, which may be
> page 1 of "英", or page 2 of "中"?
reset to the "中-1" page

> 
> 3. Will "空格“ be shown on the space bar of all Pinyin IME layouts, or only on
> the symbol layouts?
show on all Pinyin IME layouts

Comment 15

[Yuan Xulei [:yxl] (Leave from May 18)]

Luke, please update the implementation based on Jing's reply.

Comment 16

[Luke Chang [:lchang] (inactive)]

Hi Xulei,

The pull request is updated. Could you please review it again, thanks.

Comment 17

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Hi Jing,

Thanks for creating the spec of this.
Are we going to add this spec to box? 
https://mozilla.app.box.com/system/1/867860852

Comment 18

[Yuan Xulei [:yxl] (Leave from May 18)]

Comment on attachment 802160 [details]
Pull Request

r=me. It works excellently. Please fix the nits and Rudy's comments before merge.

Comment 19

[Luke Chang [:lchang] (inactive)]

Hi Xulei,
I've updated my patch. Thanks for your comments.

Comment 20

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 802160 [details]
Pull Request

r=me.

Luke, great work and sorry for the delay to get the review done.
Also thanks to Yuan for his review.

Comment 21

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Merged to Gaia master,
https://github.com/mozilla-b2g/gaia/commit/a056d0371c8a96c72f2360af61dea1dd7df6a835

Comment 22

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Please uplift.

Comment 23

[James Lal [:lightsofapollo]]

Uplifted a056d0371c8a96c72f2360af61dea1dd7df6a835 to:
v1.2: bb2e22914f881874bfc16041f2405608a6278ca8

Comment 24

[Jing Zhang]

(In reply to Rudy Lu [:rudyl] from comment #17)
> Hi Jing,
> 
> Thanks for creating the spec of this.
> Are we going to add this spec to box? 
> https://mozilla.app.box.com/system/1/867860852

clear