908595 - [marionette-helper] waitForElement function should wait for the element appended in the DOM.

Status: RESOLVED FIXED

(Testing Graveyard :: JSMarionette, defect)

Description

[Evan Tseng [:evanxd]]

We might also use the waitForElement function for waiting the element appended in the DOM and then displayed in the screen.

This situation is happened in the Bug 900894, and it make some issues in the CI. We could see the issue in https://travis-ci.org/mozilla-b2g/gaia/builds/10525606#L137.

Comment 1

[Evan Tseng [:evanxd]]

Hi Gaye,

Could you add me as owner of marionette-js-helper and marionette-client.

Then I could update some modules for fixing the Bug 900894.

Thanks. :)

Comment 2

[James Lal [:lightsofapollo]]

Evan what is your npm username? I Will add you to the client now.

Comment 3

[James Lal [:lightsofapollo]]

Looks like your already on marionette-js-helper and I just added you to the client.

Comment 4

[Evan Tseng [:evanxd]]

Hi James,

Sorry, I think that I'm not on marionette-js-helper.
I created marionette-helper(https://npmjs.org/package/marionette-helper) by my own for testing.
They are different.

Comment 5

[Evan Tseng [:evanxd]]

Hi Gaye,

Sorry for that I already merged this patch https://github.com/mozilla-b2g/marionette-helper/commit/911490841483d835f6c563291f38e45f3a6e446f into marionette-helper without your review. I just would like to fix Bug 900894 faster.

But then I found out that I'm NOT a maintainer of marionette-js-helper in npm. And I could not update the module for fixing Bug 900894.

So could you help me that let me be a maintainer of it in npm?
Thanks.

Comment 6

[Evan Tseng [:evanxd]]

Hi Gaye,

We already changed the module name for marionette-helper in NPM, and we updated the change in gaia https://github.com/mozilla-b2g/gaia/blob/master/shared/test/integration/setup.js#L3.

And you're also a maintainer of https://npmjs.org/package/marionette-helper.

Thanks. :)

Comment 7

[Evan Tseng [:evanxd]]

master: https://github.com/mozilla-b2g/marionette-helper/commit/911490841483d835f6c563291f38e45f3a6e446f

Comment 8

[Gareth Aye [:gaye] (back from PTO)]

Attachment: Pull request

Followup patch

Comment 9

[Evan Tseng [:evanxd]]

Hi Gareth,

In your patch, how do we handle the below situation?
We would like to wait for a element is appended in the DOM and showed in the screen?

waitForElement function will not work when the element isn't in DOM yet.
But I think we should wait for it appended in DOM.

How do you think?