908633 - Required field, even filling in all the fields.

Status: VERIFIED FIXED

(www.mozilla.org :: Newsletters, defect)

Description

[Rodrigo Silva]

Attachment: Captura de tela de 2013-08-23 09:17:20.png

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:23.0) Gecko/20100101 Firefox/23.0 (Beta/Release)
Build ID: 20130807180628

Steps to reproduce:

Fill all fields


Actual results:

show message : This field is required.


Expected results:

registered

Comment 1

[Jessilyn Davis]

Attachment: Screenshot of filled in fields and error

Confirmed that this is an issue. (see attached screenshot)

Mike - can you assign this to the right person to fix?

Comment 2

[Dan Poirier [:dpoirier]]

Jess: This is probably due to this particular page not displaying the language field, so it's not getting filled in. Is there any reason at this point not to display country and language fields on all the m.o newsletter signup pages?

Comment 3

[Jessilyn Davis]

We'll need a language drop-down in the semi-near future (when we're ready to launch Spanish) - right now this newsletter is in EN only. 

The way it was working before is that either there was a blank language_iso2 passed through (thus preserving any Firefox & You non-EN language), or we explicitly passed through EN, but made it so that if the language there before was non-EN, we wouldn't overwrite it; these actions happened without the language field showing.

If we wanted to add in the Language field, It would have to show only EN at this time for the choice.  And we'd want to make sure that the logic is in place that if they have a non-EN language choice in Exact Target, we do not overwrite it with "EN". (ie if they had been subscribed to the ES Firefox & You newsletter, I want them to still get the "ES" version even if they signed up for an "EN" only newsletter).

Does this help?

Comment 4

[Dan Poirier [:dpoirier]]

Okay, since this is Priority 1, for now we'll just fix the page so it works again.

Pull request opened: https://github.com/mozilla/bedrock/pull/1213

Comment 5

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/51c4f13a1c708a2c3344ff1b057d459ed6ec7852
BUg 908633 - Don't require lang field on newsletter signup

https://github.com/mozilla/bedrock/commit/65ba03c83c583359b89ee02d914fb217f976c5ee
Bug 908633 - mark lang field required in HTML

If lang field is displayed, mark it required in HTML

https://github.com/mozilla/bedrock/commit/d3a8b6f9ab86bfa5c19fcef7ec7f3ecc97015e0f
Merge pull request #1213 from dpoirier/bug-908633-required-lang-field

Bug 908633 - Don't require lang field on newsletter signup

Comment 6

[Dan Poirier [:dpoirier]]

Ready for test at https://www-dev.allizom.org/en-US/newsletter/hacks.mozilla.org/#footer-email-form

(works for me)

Comment 7

[Jessilyn Davis]

Thanks Dan!

Raymond, do you have time to test this today/tomorrow perchance?


Test 1
Go to: https://www-dev.allizom.org/en-US/newsletter/hacks.mozilla.org/#footer-email-form
Try to signup
Make sure it is successful and you receive the welcome email


Test 2
Go to: https://www-dev.allizom.org/ja/newsletter/  (it will be in English, but the language field will be blank)
Try to signup with a blank language
Make sure it errors and requires you to select a language.
Select a language and signup
Make sure you receive the subscription confirmation email in the correct language.

Comment 8

[raymond [:retornam] (inactive)]

TEST 2
https://www-dev.allizom.org/ja/newsletter/ 
verified all steps


Test 1
verified all steps

Comment 9

[Jessilyn Davis]

Thanks Raymond!

Dan - let's go to prod!

Comment 10

[Dan Poirier [:dpoirier]]

Jess: your wish is our command. It looks like this was included in yesterday's prod push and is live.

Comment 11

[Jessilyn Davis]

Dan: Thanks! I just tested and everything looks good.

[e-mail]: Thank you for alerting us to this issue!

Comment 12

[Rodrigo Silva]

Thank you guys!
See you at the Summit :)

Comment 13

[Jessilyn Davis]

Sweet! We'll see you there! :D