908644 - Add a global result summary to cppunittest output

Status: RESOLVED FIXED

(Testing :: General, defect)

Description

[Dan Minor [:dminor]]

The cppunittest harness should output a global summary of passes and fails to facilitate parsing output in mozharness.

Comment 1

[Dan Minor [:dminor]]

Attachment: Patch to add summary statistics to cppunittests

Try run: https://tbpl.mozilla.org/?tree=Try&rev=8c33fead4d92

Comment 2

[(not currently active) Ted Mielczarek]

Comment on attachment 794752 [details] [diff] [review]
Patch to add summary statistics to cppunittests

Review of attachment 794752 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/runcppunittests.py
@@ +107,5 @@
>          self.xre_path = xre_path
>          env = self.build_environment()
>          result = True
> +        passCount = 0
> +        failCount = 0

I know you probably copied this from another harness, but I'm trying to keep mostly PEP-8 style in this file, so name these pass_count and fail_count. (nitpicky, I know!)

@@ +118,1 @@
>              result = result and single_result

You can probably just ditch result altogether and return "failCount == 0". (You could dispense with the intermediate single_result variable as well, then.)

Comment 3

[Dan Minor [:dminor]]

Thanks, with comments addressed: https://hg.mozilla.org/integration/mozilla-inbound/rev/4c8d122d39df

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4c8d122d39df