Closed Bug 908644 Opened 7 years ago Closed 7 years ago

Add a global result summary to cppunittest output

Categories

(Testing :: General, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla26

People

(Reporter: dminor, Assigned: dminor)

Details

Attachments

(1 file)

The cppunittest harness should output a global summary of passes and fails to facilitate parsing output in mozharness.
Comment on attachment 794752 [details] [diff] [review]
Patch to add summary statistics to cppunittests

Review of attachment 794752 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/runcppunittests.py
@@ +107,5 @@
>          self.xre_path = xre_path
>          env = self.build_environment()
>          result = True
> +        passCount = 0
> +        failCount = 0

I know you probably copied this from another harness, but I'm trying to keep mostly PEP-8 style in this file, so name these pass_count and fail_count. (nitpicky, I know!)

@@ +118,1 @@
>              result = result and single_result

You can probably just ditch result altogether and return "failCount == 0". (You could dispense with the intermediate single_result variable as well, then.)
Attachment #794752 - Flags: review?(ted) → review+
https://hg.mozilla.org/mozilla-central/rev/4c8d122d39df
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in before you can comment on or make changes to this bug.