908701 - DeviceStorage: Cleanup apps directory determination

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Dave Hylands [:dhylands]]

The determination of root directories is currently split between InitDirs and DeviceStorageFile::GetRootDirectoryForType

The intention of this split was that directories which don't depend on a volume should be calculated once in InitDirs. Directories which depend on the root directory of a volume should be calculated in DeviceStorageFile::GetRootDirectoryForType

Point 1 - There should be some comments which make this distinction clear

Point 2 - Apps has some initialization in both places. Since the apps are not volume based, everything should be done in InitDirs.

While looking at this I also saw one occurrence of "apps" which should be replaced with DEVICESTORAGE_APPS (in the nsDOMDeviceStorage::Init function).

Comment 1

[[:fabrice] Fabrice Desré]

Attachment: patch

Comment 2

[[:fabrice] Fabrice Desré]

Attachment: patch v2

Forgot to qref my last change... This one actually compiles ;)

Comment 3

[Dave Hylands [:dhylands]]

Comment on attachment 794741 [details] [diff] [review]
patch v2

Review of attachment 794741 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with nit addressed

::: dom/devicestorage/nsDeviceStorage.cpp
@@ +629,5 @@
>  
> +#ifdef MOZ_WIDGET_GONK
> +    NS_NewLocalFile(NS_LITERAL_STRING("/data"),
> +                    false,
> +                    getter_AddRefs(sDirs->apps));

nit: this seems to indented 2 spaces too many

Comment 4

[[:fabrice] Fabrice Desré]

https://hg.mozilla.org/integration/b2g-inbound/rev/0c0ff91aa963

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/0c0ff91aa963