Avoid #including nsPresContext.h in nsIScrollableFrame.h

RESOLVED FIXED in mozilla26

Status

()

defect
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Ehsan, Assigned: Ehsan)

Tracking

(Blocks 1 bug)

Trunk
mozilla26
x86
macOS
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Posted patch Patch (v1) (obsolete) — Splinter Review
No description provided.
Attachment #794731 - Flags: review?(matspal)
Posted patch Patch (v1)Splinter Review
Wrong patch
Attachment #794731 - Attachment is obsolete: true
Attachment #794731 - Flags: review?(matspal)
Attachment #794743 - Flags: review?(matspal)
Comment on attachment 794743 [details] [diff] [review]
Patch (v1)

Looks good.  r=mats
A few nits you might want to fix while you're here:

>content/events/src/nsEventStateManager.cpp
>+  ScrollbarStyles overflowStyle =
>+                    aScrollableFrame->GetScrollbarStyles();

It looks like this would fit on one line now.

>layout/forms/nsListControlFrame.cpp
>+  return ScrollbarStyles(NS_STYLE_OVERFLOW_HIDDEN,
>+                         verticalStyle);

this too

>layout/base/ScrollbarStyles.h
>+struct ScrollbarStyles {

I know you just copy-pasted this, but { should go on its own line

>+  uint8_t mHorizontal, mVertical;

... and mVertical should be declared on its own line.
Attachment #794743 - Flags: review?(matspal) → review+
https://hg.mozilla.org/mozilla-central/rev/5a9fb1ce1de5
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in before you can comment on or make changes to this bug.