Closed
Bug 908750
Opened 11 years ago
Closed 11 years ago
Fix an exact rooting hazard in nsScriptSecurityManger::LookupPolicy
Categories
(Core :: Security: CAPS, defect)
Core
Security: CAPS
Tracking
()
RESOLVED
FIXED
mozilla27
People
(Reporter: terrence, Assigned: terrence)
References
Details
Attachments
(1 file)
|
4.54 KB,
patch
|
bholley
:
review+
|
Details | Diff | Splinter Review |
This just handlifies aProperty and adds a Handle accessor to sEnabledID. Since sEnabledID is interned, it will never be collected and can safely be referred to by a handle.
Attachment #794762 -
Flags: review?(continuation)
|
||
Updated•11 years ago
|
Component: JavaScript Engine → Security: CAPS
|
|
||
Updated•11 years ago
|
Attachment #794762 -
Flags: review?(continuation) → review?(bobbyholley+bmo)
|
||
Comment 1•11 years ago
|
||
Comment on attachment 794762 [details] [diff] [review] hazard_scriptsecman-v0.diff Review of attachment 794762 [details] [diff] [review]: ----------------------------------------------------------------- This will bitrot the patch in bug 905364 which does something similar, but is blocked on other stuff. That's ok though, I guess.
Attachment #794762 -
Flags: review?(bobbyholley+bmo) → review+
|
Assignee | |
Comment 2•11 years ago
|
||
Looks like bug 905364 has landed, so this is ready to move forward. https://hg.mozilla.org/integration/mozilla-inbound/rev/1c9f1b7a9899
|
||
Comment 3•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/1c9f1b7a9899
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in
before you can comment on or make changes to this bug.
Description
•