Closed Bug 908795 Opened 12 years ago Closed 12 years ago

Intermittent Android testClearPrivateData | Checking history exists - History exists

Categories

(Firefox for Android Graveyard :: Awesomescreen, defect)

Product:
Firefox for Android Graveyard
Component:
Awesomescreen
Platform:
ARM
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox24 unaffected, firefox25 unaffected, firefox26 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 26
Tracking Flags:
Tracking Status
firefox24 --- unaffected
firefox25 --- unaffected
firefox26 --- fixed

People

(Reporter: RyanVM, Assigned: AdrianT)

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

fix intermittent fail in testClearPrivateData
2.54 KB, patch
Margaret
: review+
Details | Diff | Splinter Review
Conveniently, the first occurrence was on the push for bug 896566. https://tbpl.mozilla.org/php/getParsedLog.php?id=26925672&tree=Fx-Team Android Tegra 250 fx-team opt test robocop-2 on 2013-08-23 08:44:25 PDT for push 617b9050b5ed slave: tegra-032 0 INFO SimpleTest START 1 INFO TEST-START | testClearPrivateData EventExpecter: no longer listening for Gecko:Ready 2 INFO TEST-PASS | testClearPrivateData | waiting for urlbar text to gain focus - urlbar text gained focus 3 INFO TEST-PASS | testClearPrivateData | URL typed properly - http://mochi.test:8888/tests/robocop/robocop_blank_01.html should equal http://mochi.test:8888/tests/robocop/robocop_blank_01.html EventExpecter: no longer listening for DOMContentLoaded 4 INFO TEST-PASS | testClearPrivateData | Inserting a new bookmark - Inserter the bookmark with the title = Browser Blank Page 02 and the url = http://mochi.test:8888/tests/robocop/robocop_blank_02.html 5 INFO TEST-UNEXPECTED-FAIL | testClearPrivateData | Checking history exists - History exists Exception caught during test! junit.framework.AssertionFailedError: 5 INFO TEST-UNEXPECTED-FAIL | testClearPrivateData | Checking history exists - History exists at junit.framework.Assert.fail(Assert.java:47) at org.mozilla.fennec.FennecMochitestAssert._logMochitestResult(FennecMochitestAssert.java:107) at org.mozilla.fennec.FennecMochitestAssert.ok(FennecMochitestAssert.java:136) at org.mozilla.fennec.tests.testClearPrivateData.clearHistory(testClearPrivateData.java:33) at org.mozilla.fennec.tests.testClearPrivateData.testClearPrivateData(testClearPrivateData.java:18) at java.lang.reflect.Method.invokeNative(Native Method) at java.lang.reflect.Method.invoke(Method.java:521) at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:204) at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:194) at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:186) at org.mozilla.fennec.tests.BaseTest.runTest(BaseTest.java:160) at junit.framework.TestCase.runBare(TestCase.java:127) at junit.framework.TestResult$1.protect(TestResult.java:106) at junit.framework.TestResult.runProtected(TestResult.java:124) at junit.framework.TestResult.run(TestResult.java:109) at junit.framework.TestCase.run(TestCase.java:118) at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:169) at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:154) at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:520) at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1447) 6 INFO TEST-UNEXPECTED-FAIL | testClearPrivateData | Exception caught - junit.framework.AssertionFailedError: 5 INFO TEST-UNEXPECTED-FAIL | testClearPrivateData | Checking history exists - History exists 7 INFO TEST-END | testClearPrivateData | finished in 37081ms 8 INFO TEST-START | Shutdown 9 INFO Passed: 3 10 INFO Failed: 2 11 INFO Todo: 0 12 INFO SimpleTest FINISHED
Assignee: nobody → adrian.tamas
Added a waitForTest when checking the size of the history item list to allow for the database operation to finish and the page to be added to history after load.
Attachment #795389 - Flags: review?(margaret.leibovic)
Comment on attachment 795389 [details] [diff] [review] fix intermittent fail in testClearPrivateData Review of attachment 795389 [details] [diff] [review]: ----------------------------------------------------------------- ::: mobile/android/base/tests/testClearPrivateData.java.in @@ +29,5 @@ > > addOrUpdateMobileBookmark(BLANK2_TITLE, blank2); > > // Checking that the history list is not empty > + verifyHistoryCount(1); I don't think we need to wait here, since addOrUpdateMobileBookmark makes DB calls on the same thread. However, it's fine to leave like this for consistency.
Attachment #795389 - Flags: review?(margaret.leibovic) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/8e79adf22902
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 26
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: