908898 - Move JS_PSG/JS_PSGS/JS_PS_END into jsapi.h

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jeff Walden [:Waldo]]

Attachment: Move the definitions, add some scattered uses outside js/

We should expose this stuff for more general use.  Various bits of code outside the JS engine could already make use of it.

The type-checking finickiness here has passed try, at least scattered across various try-pushes, but I don't have the URLs quite handy right now.  I'll probably do a precautionary final push of it just to be safe before landing.

If you have better ideas for how to do that type-checking, I'm all ears, but I don't see much.  Implicit conversion of functions to function pointers is usually pretty nice, but it hurts a bit here.

Comment 1

[Jeff Walden [:Waldo]]

Attachment: Better idea

Actually, a better idea -- pass the value to a function taking a JSNative argument.  If it compiles, the value will convert to JSNative, and we're good.  This should work everywhere, without needing to worry about decltype and other madness.

Comment 2

[Jason Orendorff [:jorendorff]]

Comment on attachment 794931 [details] [diff] [review]
Better idea

Review of attachment 794931 [details] [diff] [review]:
-----------------------------------------------------------------

Very nice.

Comment 3

[Jeff Walden [:Waldo]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5991872b4ce3

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/5991872b4ce3

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/1ee91c4cf828