908910 - [Australis] More precision and control for adding toolbar items

Status: RESOLVED DUPLICATE of bug 880388

(Firefox :: Toolbars and Customization, defect)

Description

[Chenxia Liu [:liuche]]

Adding icons to the toolbar during customization isn't particularly precise, and the shifting behavior of other icons in the toolbar to accommodate the new icon is inconsistent.

A few main points:
- When positioning an icon over the toolbar, what causes the shifting of the other icons. Location of my mouse pointer? Edge of the icon? Edge of the box around the icon? Sometimes the urlbar shifts right for no apparent reason.

- The light blue box around the icon is much too large if you drag something from the customization screen to add to the toolbar. If you drop the icon into the tabs row and then pick it up again, the box shrinks to size of the icon, which feels less awkward and conveys a sense of more precision.

- Selecting an icon to be added displays a "handgrab" mousepointer, but this reverts to a normal pointer outside of the browser window and does not revert after returning to the browser space.

- If there exist icons to the right of urlbar/search bar, it doesn't seem possible to add an icon to the right-most position.

Taking screenshots while using mouse seems to be non-trivial, so there are none attached.

Comment 1

[Matthew N. [:MattN]]

This should probably be split into multiple bugs but thanks for reporting these.

(In reply to Chenxia Liu [:liuche] from comment #0)
> Adding icons to the toolbar during customization isn't particularly precise,
> and the shifting behavior of other icons in the toolbar to accommodate the
> new icon is inconsistent.
> 
> A few main points:
> - When positioning an icon over the toolbar, what causes the shifting of the
> other icons. Location of my mouse pointer? Edge of the icon? Edge of the box
> around the icon? Sometimes the urlbar shifts right for no apparent reason.
> 
> - The light blue box around the icon is much too large if you drag something
> from the customization screen to add to the toolbar. If you drop the icon
> into the tabs row and then pick it up again, the box shrinks to size of the
> icon, which feels less awkward and conveys a sense of more precision.
> 
> - Selecting an icon to be added displays a "handgrab" mousepointer, but this
> reverts to a normal pointer outside of the browser window and does not
> revert after returning to the browser space.
> 
> - If there exist icons to the right of urlbar/search bar, it doesn't seem
> possible to add an icon to the right-most position.

Marking as a regression and P3 because of this.

Comment 2

[:Gijs (he/him)]

(In reply to Chenxia Liu [:liuche] from comment #2)
> - The light blue box around the icon is much too large if you drag something
> from the customization screen to add to the toolbar. If you drop the icon
> into the tabs row and then pick it up again, the box shrinks to size of the
> icon, which feels less awkward and conveys a sense of more precision.

This is bug 880388.

Comment 3

[Mike de Boer [:mikedeboer]]

(In reply to Chenxia Liu [:liuche] from comment #0)
> A few main points:
> - When positioning an icon over the toolbar, what causes the shifting of the
> other icons. Location of my mouse pointer? Edge of the icon? Edge of the box
> around the icon? Sometimes the urlbar shifts right for no apparent reason.

Fixed in bug 923439.

> - The light blue box around the icon is much too large if you drag something
> from the customization screen to add to the toolbar. If you drop the icon
> into the tabs row and then pick it up again, the box shrinks to size of the
> icon, which feels less awkward and conveys a sense of more precision.

Fixed in bug 880388.

> - Selecting an icon to be added displays a "handgrab" mousepointer, but this
> reverts to a normal pointer outside of the browser window and does not
> revert after returning to the browser space.

I seem to remember Jaws saying this is a browser/ platform bug. I'll needinfo him.

> - If there exist icons to the right of urlbar/search bar, it doesn't seem
> possible to add an icon to the right-most position.

Also fixed in bug 923439.

Liu, I think there's not much left in this bug to fix here. Can you confirm that?

Comment 4

[:Gijs (he/him)]

(In reply to Mike de Boer [:mikedeboer] from comment #3)
> (In reply to Chenxia Liu [:liuche] from comment #0)
> > - Selecting an icon to be added displays a "handgrab" mousepointer, but this
> > reverts to a normal pointer outside of the browser window and does not
> > revert after returning to the browser space.
> 
> I seem to remember Jaws saying this is a browser/ platform bug. I'll
> needinfo him.

Yes, bug 876875.

Comment 5

[Chenxia Liu [:liuche]]

Thanks for linking to the other bugs - I still actually see a few of these in the latest UX nightly (2013-10-23) but I'll dupe this and comment in those bugs.