908917 - Search not finding correct group info

Status: VERIFIED FIXED

(Participation Infrastructure :: Phonebook, defect)

Description

[Rebecca Billings [:rbillings]]

Mozillians on production and staging is finding no results for multiple groups/functional areas, or too much info. Initially I thought it was groups with spaces in the name, but that is not it. I also suspected it was the number of participants, but that's not it either. At least the failures are reproducible.

1) Functional Groups
https://mozillians.allizom.org/en-US/search/?q=ugly+tuna = no results
Missing > https://mozillians.allizom.org/en-US/group/ugly-tuna/

2) Groups 
https://mozillians.allizom.org/en-US/search/?q=amo
Missing > https://mozillians.allizom.org/en-US/group/amo-alumni/

3) Groups
https://mozillians.allizom.org/en-US/search/?q=afrosdwilsh+fans = 14 results, none of which are on the actual group page:
https://mozillians.allizom.org/en-US/group/afrosdwilsh-fans/

Comment 1

[Giorgos Logiotatidis [:giorgos]]

This is a feature, not a bug!

Group search only displays groups with at least 3 members in them, so that would explain why you get no results for these groups.

Maybe we need to re-define behavior since this decision is quite old, although I think is good to have this limit.

Thoughts williamr, hoosteno?

Comment 2

[William Reynolds [:williamr]]

(In reply to Giorgos Logiotatidis [:giorgos] from comment #1)
> Group search only displays groups with at least 3 members in them, so that
> would explain why you get no results for these groups.
> 
> Maybe we need to re-define behavior since this decision is quite old,
> although I think is good to have this limit.

The current behavior seems reasonable to me, since most searches are for popular groups. Without a limit I think we would see results that are not relevant to what the user is searching for.

Comment 3

[Matt Brandt [:mbrandt]]

I'd actually weigh in opposite to willimr (comment 2) - I think we should remove the limiter and return results for people in groups < 3.

When a user is searching for groups that they identify with they may cast a wide net. They may end up creating new groups not realizing a similar one already exists.

Comment 4

[Rebecca Billings [:rbillings]]

Two things:
1. the Functional Group from 1) has 22 members - so I don't see why it wouldn't find it. 
2. the results from Groups 3) show members who don't have the search term in their profile.

I also think that search results shouldn't display/not-display based on a limit, but that's just my 2 cents.

Comment 5

[Justin Crawford [:hoosteeno] [:jcrawford]]

I agree with comments 3 and 4

* The limit is arbitrary and undocumented and creates unexpected behavior (which makes people say, "search doesn't work"). The fix for bad data is to clean it up, not hide it, and we have had an open bug to do just that for months.
* This bug actually describes an instance when search appears not to work.

Comment 6

[Giorgos Logiotatidis [:giorgos]]

(In reply to Rebecca Billings [:rbillings] from comment #4)
> Two things:
> 1. the Functional Group from 1) has 22 members - so I don't see why it
> wouldn't find it. 

It wouldn't find it because the cronjob setting the 'autocomplete' flag when the group reaches 3 participants was disabled for stage. That is now solved with bug 909261.

> 2. the results from Groups 3) show members who don't have the search term in
> their profile.
> 
They have the word 'fan' in their profile, that's why they come up in the search.

Comment 7

[Giorgos Logiotatidis [:giorgos]]

With Curated Groups refactoring we removed the "autocomplete" feature from groups and we list all _visible_ groups in search.

By default all groups are visible. Only special groups, managed by admins, can be set invisible.

I believe this resolves the bug as WFM. Thanks for reporting Rebecca

Comment 8

[Matt Brandt [:mbrandt]]

Bumping to verified -- the updates in behavior from bug 909261 appear to have remedied this.