If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

[browser] icon uri does not update

RESOLVED WORKSFORME

Status

Firefox OS
Gaia::Browser
RESOLVED WORKSFORME
4 years ago
3 years ago

People

(Reporter: nhirata, Unassigned)

Tracking

({regression})

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: sprintready)

Attachments

(1 attachment)

commit 5910944bc3cd4a263299431a3832c5582325f393 
Build 8/23/2013

1. modify the <b2g>/build/applications-data.js to include a bookmark without a uri
2. go to that url (ie http://www.cnn.com/ )
3. once it finishes loading tap on the url bar then tap on the top sites as well as bookmarks

Expected: the icon uri should update
Actual: the icon uri does not update
Created attachment 794946 [details]
applications-data.js
I had tried to unbookmark and rebookmark it, the icon does not populate:

E/GeckoConsole( 1492): [JavaScript Warning: "Error in parsing value for 'transition-duration'.  Declaration dropped." {file: "http://www.cnn.com/" line: 0 column: 0 source: "0"}]
E/GeckoConsole( 1492): [JavaScript Warning: "Error in parsing value for 'transition-duration'.  Declaration dropped." {file: "http://www.cnn.com/" line: 0 column: 0 source: "0"}]
regression
Flags: needinfo?(krudnitski)
Flags: needinfo?(blassey.bugs)
Flags: needinfo?(bfrancis)
Keywords: regression

Updated

4 years ago
Flags: needinfo?(krudnitski)
I'm not sure this is a regression as it may always have been this way, but I'm surprised it doesn't work.

I would assume that when setting default bookmarks partners would want to provide icons, so that the bookmarks don't get displayed with placeholder icons before they've been navigated to.

It's a bug we should fix but I don't think it's a huge priority unless we hear otherwise from partners.
Flags: needinfo?(bfrancis)
If this is the case where the default thumbnail appears as an icon until a user actually taps on the link and visits the page (and THEN the thumbnail is populated with a snapshot of the page), then no - this is not a high priority to fix. I expect this to require some thought and don't think it will be an easy one to fix (and there are other higher prio bugs in our backlog).

When we think this is sprintready, I can place it in our backlog accordingly.
(In reply to Karen Rudnitski [:kar] from comment #5)
> If this is the case where the default thumbnail appears as an icon until a
> user actually taps on the link and visits the page (and THEN the thumbnail
> is populated with a snapshot of the page), then no - this is not a high
> priority to fix.

That doesn't happen on Firefox OS, perhaps you are thinking of Fennec.

This is about the favicons for default bookmarks not being updated in the awesomescreen if a preloaded bookmark was provided with a blank icon URI.
So this is the favicon and not the thumbnail image itself? (why would we accept a preloaded bookmark without the favicon details, out of curiosity? would that not solve the issue?)
what info do you need from me?
Flags: needinfo?(blassey.bugs)
Just calling attention to this bug, blassey.  Thanks.
Whiteboard: sprintready

Comment 10

4 years ago
A Pivotal Tracker story has been created for this Bug: http://www.pivotaltracker.com/story/show/57483762
Does this still reproduce?
Lets reopen if its still shows up.
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.