[Buri][WIFI]Can't turn on/off wifi from pull down state bar

RESOLVED FIXED

Status

P1
normal
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: sync-1, Assigned: vchang)

Tracking

unspecified

Firefox Tracking Flags

(blocking-b2g:leo+, b2g18 fixed, b2g-v1.1hd fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
Firefox os  v1.1
 Mozilla build ID:20130817041203
 
 DEFECT DESCRIPTION:
  Can't turn on/off wifi from pull down state bar
 
  REPRODUCING PROCEDURES:
  1.turn on wifi,connect a ap successful
  2.turn on wifi hotspot, turn off wifi hotspot
  3.the wifi will turn on automactily.
  4.pull down state bar,can't turn off wifi via status bar->KO
 
  EXPECTED BEHAVIOUR:
 
  ASSOCIATE SPECIFICATION:
 
  TEST PLAN REFERENCE:
 
  TOOLS AND PLATFORMS USED:
 
  USER IMPACT:mid
 
  REPRODUCING RATE:5/5
 
  For FT PR, Please list reference mobile's behavior:

Comment 1

5 years ago
Hi Chuck,

This issue maybe flow problems, please help check. Thanks.

For step 2, when turn off hotspot, settings and system all all wifiManager.onenabled. In settings,  it will call  "settings.createLock().set({'wifi.enabled': true})" and In system, it will call "delete this.wifi.dataset.initializing;", but in quick_settings.js  it will call "self.wifi.dataset.initializing = 'true';" . So when we click wifi icon, it will return, doesn't turn on/off wifi.

Updated

5 years ago
Flags: needinfo?(chulee)

Updated

5 years ago
blocking-b2g: --- → leo?

Updated

5 years ago
Flags: needinfo?(vchang)
Regression => leo+
blocking-b2g: leo? → leo+
QA,

Please confirm if this issue is reproducible in latest build.
Keywords: qawanted

Updated

5 years ago
QA Contact: laliaga

Comment 4

5 years ago
Repro'd on a Buri device on the latest 1.1. Unable to toggle Wifi on/off after turning hotspot on then off.

Environmental Variables
Build ID: 20130903041201
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/9da3739ce7d7
Gaia: 8dc90703f4151d6f2a0decede0ee702f425a3a38
Platform Version: 18.1
RIL Version: 01.01.00.019.211
Keywords: qawanted
(Assignee)

Updated

5 years ago
Assignee: nobody → vchang
Flags: needinfo?(vchang)

Comment 5

5 years ago
Any updates?
(Assignee)

Comment 6

5 years ago
Created attachment 801467 [details]
Patch v1.0
Attachment #801467 - Flags: review?(arthur.chen)
Attachment #801467 - Attachment is patch: false
Attachment #801467 - Attachment mime type: text/plain → text/html
Clear needinfo since Vincent is handling it.
Flags: needinfo?(chulee)
Vincent, thanks for the effort. 

I've tested the patch and found that we only need the changes of quick_settings.js to solve the bug. I was wondering that is the changes of wifi.js and connectivity.js are necessary or just a improvement?
Flags: needinfo?(vchang)
Comment on attachment 801467 [details]
Patch v1.0

Additional review request for the system app.
Attachment #801467 - Flags: review?(alive)
(Assignee)

Comment 10

5 years ago
(In reply to Arthur Chen [:arthurcc] from comment #8)
> Vincent, thanks for the effort. 
> 
> I've tested the patch and found that we only need the changes of
> quick_settings.js to solve the bug. I was wondering that is the changes of
> wifi.js and connectivity.js are necessary or just a improvement?
Hi Arthur, you are right. It seems that we just need to modify quick_settings.js to solve the problem. Maybe we can keep the others change for now ? But using settings to notify wifi status is weird to me.
Flags: needinfo?(vchang)
(Assignee)

Comment 11

5 years ago
I have posted the new patch to github to address the review comment.
Comment on attachment 801467 [details]
Patch v1.0

Cancel the review since the updated patch does not include changes to the settings app.
Attachment #801467 - Flags: review?(arthur.chen)
Comment on attachment 801467 [details]
Patch v1.0

I don't know why we don't have this before.
Is there any difference about wifi.enabled settings and wifiManager.onenabled ?
Attachment #801467 - Flags: review?(alive) → review+
https://github.com/mozilla-b2g/gaia/commit/416b129d78addce75f323ebaf286d13e6ff97063
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
John, can you assist with the v1-train uplift please? :)
Flags: needinfo?(jhford)
[v1-train 63bdb10]
status-b2g18: --- → fixed
Flags: needinfo?(jhford)
v1.1.0hd: 63bdb10815890686d62303c16e9e5a2eaf75f3f5
status-b2g-v1.1hd: --- → fixed
You need to log in before you can comment on or make changes to this bug.