If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

test_reftests_with_caret.html failing on b2g mochitest because of spellcheck test

RESOLVED FIXED in mozilla26

Status

()

Core
Editor
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: Martijn Wargers (dead), Assigned: Martijn Wargers (dead))

Tracking

Trunk
mozilla26
x86
Mac OS X
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

4 years ago
Created attachment 795095 [details] [diff] [review]
test_reftests_with_caret.diff

This test file is disabled on b2g and Android.
I noticed there is 1 failure (out of 31) on b2g mochitest, because there is a test in it that uses spellcheck. Spellcheck is currently disabled on b2g and Android.

This immediately reminded me of bug 634626.

In this case, the test file shouldn't be disabled completely on Android and b2g, because the other tests are unrelated to spellcheck.

It seems to the patch I attached is the best solution and is similar to what you wanted in bug 634626, right?
Attachment #795095 - Flags: review?(ehsan)
Comment on attachment 795095 [details] [diff] [review]
test_reftests_with_caret.diff

Review of attachment 795095 [details] [diff] [review]:
-----------------------------------------------------------------

Yep, thanks!
Attachment #795095 - Flags: review?(ehsan) → review+
(Assignee)

Comment 2

4 years ago
Created attachment 795469 [details] [diff] [review]
909043.diff (for check-in)

I'll later remove this test file from b2g.json and android.json (along with some other test files from other bugs)
Attachment #795095 - Attachment is obsolete: true
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
https://hg.mozilla.org/integration/b2g-inbound/rev/551f334744e4
Flags: in-testsuite+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/551f334744e4
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in before you can comment on or make changes to this bug.