Closed Bug 909058 Opened 11 years ago Closed 11 years ago

Icons shift right when selecting (a) message(s)

Categories

(SeaMonkey :: Themes, defect)

SeaMonkey 2.20 Branch
x86
macOS
defect
Not set
normal

Tracking

(seamonkey2.20 wontfix, seamonkey2.21 fixed)

RESOLVED FIXED
seamonkey2.21
Tracking Status
seamonkey2.20 --- wontfix
seamonkey2.21 --- fixed

People

(Reporter: mfidelman, Unassigned)

Details

(Keywords: classic)

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:23.0) Gecko/20100101 Firefox/23.0 SeaMonkey/2.20 (Beta/Release)
Build ID: 20130803200527

Steps to reproduce:

3-pane view. Select a folder. Select a message.


Actual results:

Icons in the toolbar shift slightly to the right. Just enough to be disconcerting and mess with muscle memory when moving one's mouse to click on an action.


Expected results:

Nothing.  (All the icons should have remained in the same places in the icon bar).
Which theme are you using (SeaMonkey Default, SeaMonkey Modern, something else and what)? Do you see the problem with both standard themes?

Are you using "big" or "small" icons? With or without text? If with text: "under" the icons or "beside" them?

(I'm on Linux using a third-party theme, "EarlyBlue" by Robert Kaiser, with small icons and no text. With these settings the icons on my toolbar remain pixelwise immobile when I select a message. What does happen is that some of them go into or out of greyed-out state but with no change in their position and width).

Also: do you have custom icons (from an extension, maybe) on the same toolbar?
Flags: needinfo?(mfidelman)
Default theme.  No custom icons.
Flags: needinfo?(mfidelman)
Just tried w/ Modern theme - problem goes away, but.. modern theme is but ugly (at least on my Mac).
(In reply to Miles Fidelman from comment #3)
> Just tried w/ Modern theme - problem goes away, but.. modern theme is but
> ugly (at least on my Mac).

Well, at least it tells us that of the two themes distributed with SeaMonkey, only the default theme has the problem. About which one is prettier or uglier than the other, “beauty is in the eye of the beholder”.
Component: MailNews: Message Display → Themes
Keywords: classic
The "toolbar" here is the main toolbar?
(In reply to Stefan [:stefanh] from comment #5)
> The "toolbar" here is the main toolbar?

AFAICT, the 3-pane window has only one toolbar with icons on it, so yes, it is the main MailNews toolbar.
(In reply to Tony Mechelynck [:tonymec] from comment #6)
> (In reply to Stefan [:stefanh] from comment #5)
> > The "toolbar" here is the main toolbar?
> 
> AFAICT, the 3-pane window has only one toolbar with icons on it, so yes, it
> is the main MailNews toolbar.

OK, I'll take a look (might take a few days before I get to it, thought).
Setting needinfo on myself as a reminder
Flags: needinfo?(stefanh)
OK, so this regressed 2013-04-23 when one of the patches in bug 748894 landed that added left/right padding to the .toolbarbutton-menubutton-dropmarker in toolkit/themes/osx/global/toolbarbutton.css. Unfortunately, no one noticed that the disabled dropmarker was styled with 'padding: 0 !important;'. These changes landed for Firefox 23 and SeaMonkey 2.20 is using that code.

But: This this got fixed when bug 865316 was fixed (https://bugzilla.mozilla.org/show_bug.cgi?id=865316#c9) - the padding rule was removed for the disabled .toolbarbutton-menubutton-dropmarker. Now, the changes in bug 865316 went after the uplift, so these changes are in Firefox 24 (SeaMonkey 21).

IOTW: this should be fixed for 2.21
Flags: needinfo?(stefanh)
And I can confirm that this is fixed in the next release - just tested a 2.21 beta build.
--> Fixed (in bug 865316)
Status: UNCONFIRMED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.21
(In reply to Stefan [:stefanh] from comment #10)
> And I can confirm that this is fixed in the next release - just tested a
> 2.21 beta build.
> --> Fixed (in bug 865316)

This means it is 2.20-wontfix? Or doesn't it?
Status: RESOLVED → UNCONFIRMED
Resolution: FIXED → ---
Target Milestone: seamonkey2.21 → ---
2.20 is already released so I don't see how it could get fixed there.
(In reply to Stefan [:stefanh] from comment #12)
> 2.20 is already released so I don't see how it could get fixed there.

Just to be sure how to set the tracking flags. Also I see that in comment #11 I unwittedly undid your resolution, let's correct that too.
Status: UNCONFIRMED → RESOLVED
Closed: 11 years ago11 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.21
You need to log in before you can comment on or make changes to this bug.