Closed
Bug 909065
Opened 11 years ago
Closed 11 years ago
Call property_get and property_set directly from WifiWorker.js
Categories
(Firefox OS Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: fabrice, Assigned: fabrice)
References
Details
Attachments
(1 file, 1 obsolete file)
|
3.43 KB,
patch
|
mrbkap
:
review+
|
Details | Diff | Splinter Review |
We currently run these on another thread, but that's just useless overhead.
|
Assignee | |
Comment 1•11 years ago
|
||
Assignee: nobody → fabrice
Attachment #795117 -
Flags: review?(mrbkap)
|
|
Assignee | |
Comment 2•11 years ago
|
||
Blake, I removed getProperty that was unused (all call sites just use libcutils.property_get()) but I kept setProperty because call sites rely on the boolean return value that itself needs the try/catch...
Attachment #795117 -
Attachment is obsolete: true
Attachment #795117 -
Flags: review?(mrbkap)
Attachment #796157 -
Flags: review?(mrbkap)
|
||
Comment 3•11 years ago
|
||
Comment on attachment 796157 [details] [diff] [review] patch v2 Review of attachment 796157 [details] [diff] [review]: ----------------------------------------------------------------- Please add a comment to setProperty noting that it's no longer an asynchronous API.
Attachment #796157 -
Flags: review?(mrbkap) → review+
|
|
Assignee | |
Comment 4•11 years ago
|
||
https://hg.mozilla.org/integration/b2g-inbound/rev/49e21f2559fe
|
||
Comment 5•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/49e21f2559fe
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
||
Updated•9 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•