Closed Bug 909065 Opened 6 years ago Closed 6 years ago

Call property_get and property_set directly from WifiWorker.js

Categories

(Firefox OS Graveyard :: General, defect)

All
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: fabrice, Assigned: fabrice)

References

Details

Attachments

(1 file, 1 obsolete file)

We currently run these on another thread, but that's just useless overhead.
Attached patch patch (obsolete) — Splinter Review
Assignee: nobody → fabrice
Attachment #795117 - Flags: review?(mrbkap)
Attached patch patch v2Splinter Review
Blake, I removed getProperty that was unused (all call sites just use libcutils.property_get()) but I kept setProperty because call sites rely on the boolean return value that itself needs the try/catch...
Attachment #795117 - Attachment is obsolete: true
Attachment #795117 - Flags: review?(mrbkap)
Attachment #796157 - Flags: review?(mrbkap)
Comment on attachment 796157 [details] [diff] [review]
patch v2

Review of attachment 796157 [details] [diff] [review]:
-----------------------------------------------------------------

Please add a comment to setProperty noting that it's no longer an asynchronous API.
Attachment #796157 - Flags: review?(mrbkap) → review+
https://hg.mozilla.org/mozilla-central/rev/49e21f2559fe
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
No longer blocks: 989303
Depends on: 989303
You need to log in before you can comment on or make changes to this bug.