909072 - Event titles wrap instead of crop in month view, icons are not visible anymore

Status: RESOLVED FIXED

(Calendar :: Calendar Frontend, defect)

Description

[Geoff Lankow (:darktrojan)]

Attachment: before and after bug 781424

Events with names too long for the box used to crop with an ellipsis, now they wrap and overflow.

Comment 1

[Markus Adrario [:Taraman]]

Also the Alarm.Icon gets hidden in case of a long title.

Comment 2

[Stefan Sitter [:ssitter]]

The 'icons are not displayed' problem exists in all views. In day and week view you can observe it for all-day events, in multiweek and month view for all events.

In addition events in today pane take up many lines now rendering the agenda list view rather unusable because you only see very few events.

Please provide an option to revert to the condensed, overview like agenda view.

Comment 3

[Markus Adrario [:Taraman]]

The problem is that the label does not crop but breaks the title in multiple lines and that breaks the layout.
Up to now I don't know why. Maybe there is a difference in the handling of "value" and "textContent" of a label. Maybe it's a bug, because the documentation on the label says that the "textContent" is also cropped if "crop" is set.

I fear I will not have time to look into this until after my vacation.

Comment 4

[Markus Adrario [:Taraman]]

Attachment: Patch V1

It looks like the handling of textContent in the label is not behaving as expected. The crop attribute does not seem to have any effect.
So if in the views the value is used again ISO of textContent, the ellipsis appears again and the text is properly cropped.

This patch fixes this.

Comment 5

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 823393 [details] [diff] [review]
Patch V1

Ok, lets do it. I know there is different handling between textContent/value but it seems its not documented.

Since you are here, might want to change calGetString to cal.calGetString

Comment 6

[Markus Adrario [:Taraman]]

With the change:

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/c4af6c31dee7>
Pushed to comm-beta <http://hg.mozilla.org/releases/comm-aurora/rev/cdd96a521267>
Pushed to comm-aurora <http://hg.mozilla.org/releases/comm-beta/rev/b4db464bfff1>


-> FIXED