909077 - Remove useless STATIC_DIRS and EXTERNAL_DIRS variables

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

EXTERNAL_DIRS has no rule anymore, and STATIC_DIRS is only defined with tier static dirs, and when both are defined, only the latter is taken into account anyways.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Remove useless STATIC_DIRS and EXTERNAL_DIRS variables

Comment 2

[Gregory Szorc [:gps]]

Comment on attachment 795125 [details] [diff] [review]
Remove useless STATIC_DIRS and EXTERNAL_DIRS variables

Review of attachment 795125 [details] [diff] [review]:
-----------------------------------------------------------------

static dirs is an abomination and was only carried forward to maintain parity with pre-mozbuild. Thanks for starting to kill it.

::: python/mozbuild/mozbuild/backend/recursivemake.py
@@ -342,5 @@
>                      tier, ' '.join(obj.tier_static_dirs[tier])))
> -                fh.write('STATIC_DIRS += $(tier_%s_staticdirs)\n' % tier)
> -
> -                static = ' '.join(obj.tier_static_dirs[tier])
> -                fh.write('EXTERNAL_DIRS += %s\n' % static)

Surely removing these fails a unit test?

Comment 3

[Mike Hommey [:glandium]]

(In reply to Gregory Szorc [:gps] from comment #2)
> ::: python/mozbuild/mozbuild/backend/recursivemake.py
> @@ -342,5 @@
> >                      tier, ' '.join(obj.tier_static_dirs[tier])))
> > -                fh.write('STATIC_DIRS += $(tier_%s_staticdirs)\n' % tier)
> > -
> > -                static = ' '.join(obj.tier_static_dirs[tier])
> > -                fh.write('EXTERNAL_DIRS += %s\n' % static)
> 
> Surely removing these fails a unit test?

AFAICT, this code doesn't have a unit test.

Comment 4

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4e521461b8da

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/4e521461b8da