Closed Bug 909077 Opened 7 years ago Closed 7 years ago

Remove useless STATIC_DIRS and EXTERNAL_DIRS variables

Categories

(Firefox Build System :: General, defect)

x86_64
Linux
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla26

People

(Reporter: glandium, Assigned: glandium)

Details

Attachments

(1 file)

EXTERNAL_DIRS has no rule anymore, and STATIC_DIRS is only defined with tier static dirs, and when both are defined, only the latter is taken into account anyways.
Comment on attachment 795125 [details] [diff] [review]
Remove useless STATIC_DIRS and EXTERNAL_DIRS variables

Review of attachment 795125 [details] [diff] [review]:
-----------------------------------------------------------------

static dirs is an abomination and was only carried forward to maintain parity with pre-mozbuild. Thanks for starting to kill it.

::: python/mozbuild/mozbuild/backend/recursivemake.py
@@ -342,5 @@
>                      tier, ' '.join(obj.tier_static_dirs[tier])))
> -                fh.write('STATIC_DIRS += $(tier_%s_staticdirs)\n' % tier)
> -
> -                static = ' '.join(obj.tier_static_dirs[tier])
> -                fh.write('EXTERNAL_DIRS += %s\n' % static)

Surely removing these fails a unit test?
Attachment #795125 - Flags: review?(gps) → review+
(In reply to Gregory Szorc [:gps] from comment #2)
> ::: python/mozbuild/mozbuild/backend/recursivemake.py
> @@ -342,5 @@
> >                      tier, ' '.join(obj.tier_static_dirs[tier])))
> > -                fh.write('STATIC_DIRS += $(tier_%s_staticdirs)\n' % tier)
> > -
> > -                static = ' '.join(obj.tier_static_dirs[tier])
> > -                fh.write('EXTERNAL_DIRS += %s\n' % static)
> 
> Surely removing these fails a unit test?

AFAICT, this code doesn't have a unit test.
https://hg.mozilla.org/mozilla-central/rev/4e521461b8da
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.