Closed
Bug 909099
Opened 11 years ago
Closed 11 years ago
Load the debugger panel with the devtools loader
Categories
(DevTools :: Debugger, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 26
People
(Reporter: dcamp, Assigned: dcamp)
Details
Attachments
(1 file)
|
4.70 KB,
patch
|
vporof
:
review+
gps
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #795141 -
Flags: review?(vporof)
|
Assignee | |
Comment 1•11 years ago
|
||
Comment on attachment 795141 [details] [diff] [review] debugger-loader.diff And a hopefully-trivial build review.
Attachment #795141 -
Flags: review?(gps)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 795141 [details] [diff] [review] debugger-loader.diff Review of attachment 795141 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/devtools/debugger/debugger-panel.js @@ +22,5 @@ > this.unhighlightWhenResumed = this.unhighlightWhenResumed.bind(this); > > EventEmitter.decorate(this); > } > +exports.DebuggerPanel = DebuggerPanel; Nit: newline before this.
Attachment #795141 -
Flags: review?(vporof) → review+
|
||
Comment 3•11 years ago
|
||
Comment on attachment 795141 [details] [diff] [review] debugger-loader.diff Review of attachment 795141 [details] [diff] [review]: ----------------------------------------------------------------- You don't need a build peer review for this. But I'll give it to you anyway.
Attachment #795141 -
Flags: review?(gps) → review+
|
|
Assignee | |
Comment 4•11 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/d35877be4ec3
Assignee: nobody → dcamp
Whiteboard: [fixed-in-fx-team]
|
||
Comment 5•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/d35877be4ec3
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 26
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•