909194 - (now) Incorrect assumptions about endianness on powerpc

Status: RESOLVED FIXED

(NSPR :: NSPR, defect, P1)

Description

[[e-mail]]

Attachment: 01-nspr.patch

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:23.0) Gecko/20100101 Firefox/23.0 (Beta/Release)
Build ID: 20130807125118

Steps to reproduce:

nspr/pr/include/md/_linux.cfg encodes that powerpc is always big endian.  There are now little endian systems in existence and will become more prevelant.

The attached patch checks the __BYTE_ORDER__ define from the compiler to correctly set IS_LITTLE_ENDIAN  and IS_BIG_ENDIAN.  This issue also affects NSS (when distributed with embedded NSPR)

Comment 1

[Wan-Teh Chang]

Tony: thank you very much for the patch. Your patch is correct.
We will most likely test the __LITTLE_ENDIAN__ macro instead,
which is more concise and already being used in _darwin.cfg.

Comment 2

[Wan-Teh Chang]

Fixed by the patch in bug 977685:
https://hg.mozilla.org/projects/nspr/rev/518fcfc7b25b

Tony, I'm sorry I forgot to recognize your contribution in the
commit message for that patch, even though I had reminded
someone else to do so in bug 977685 comment 2 :-(

Comment 3

[[e-mail]]

(In reply to Wan-Teh Chang from comment #2)
> Fixed by the patch in bug 977685:
> https://hg.mozilla.org/projects/nspr/rev/518fcfc7b25b

Great!
 
> Tony, I'm sorry I forgot to recognize your contribution in the
> commit message for that patch, even though I had reminded
> someone else to do so in bug 977685 comment 2 :-(

No problem, having the issues fixed is more important.