Closed Bug 909323 Opened 6 years ago Closed 6 years ago

Improve jit-tests ADB support.

Categories

(Core :: JavaScript Engine, defect)

ARM
Android
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla26

People

(Reporter: dougc, Assigned: dougc)

References

Details

Attachments

(1 file)

Testing of the new jit-tests mobile support using ADB for transport
shows a few issues to address:

* Add support for specifying the remote ADB device serial number.

* Fix some typos in the ADB network path code.

* Increase the timeout when pushing all the tests across.  It's
already close to the default of 300 seconds on a faster device,
so double it to 600 seconds.

* There is a stall pushing the tests across, see bug 909265.
* Add a '--deviceSerial' argument to jit_test.py for specifying
the remote ADB device serial number.

* Fix some typos in 'run_tests_remote' in the ADB tcpip path,
and support the 'deviceSerial' argument.

* Add a 'timeout' argument to 'pushDir' and use it to increase
the timeout to 600 seconds when pushing all the tests.
Assignee: general → dtc-moz
Attachment #795417 - Flags: review?(terrence)
Comment on attachment 795417 [details] [diff] [review]
Improve ADB support

Review of attachment 795417 [details] [diff] [review]:
-----------------------------------------------------------------

Excellent! Thank you for fixing our ADB support! Dan and I did not spend any time on it because of the long transfer times and our tight schedule.

r=me
Attachment #795417 - Flags: review?(terrence) → review+
Yes, thanks for looking at this!
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/eb191de7ce41
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in before you can comment on or make changes to this bug.