909323 - Improve jit-tests ADB support.

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Douglas Crosher [:dougc]]

Testing of the new jit-tests mobile support using ADB for transport
shows a few issues to address:

* Add support for specifying the remote ADB device serial number.

* Fix some typos in the ADB network path code.

* Increase the timeout when pushing all the tests across.  It's
already close to the default of 300 seconds on a faster device,
so double it to 600 seconds.

* There is a stall pushing the tests across, see bug 909265.

Comment 1

[Douglas Crosher [:dougc]]

Attachment: Improve ADB support

* Add a '--deviceSerial' argument to jit_test.py for specifying
the remote ADB device serial number.

* Fix some typos in 'run_tests_remote' in the ADB tcpip path,
and support the 'deviceSerial' argument.

* Add a 'timeout' argument to 'pushDir' and use it to increase
the timeout to 600 seconds when pushing all the tests.

Comment 2

[Terrence Cole [:terrence]]

Comment on attachment 795417 [details] [diff] [review]
Improve ADB support

Review of attachment 795417 [details] [diff] [review]:
-----------------------------------------------------------------

Excellent! Thank you for fixing our ADB support! Dan and I did not spend any time on it because of the long transfer times and our tight schedule.

r=me

Comment 3

[Dan Minor [:dminor]]

Yes, thanks for looking at this!

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/eb191de7ce41

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/eb191de7ce41