Closed
Bug 909335
Opened 11 years ago
Closed 11 years ago
double pasting in HTML editor like etherpad with keyboard shortcut
Categories
(Core :: DOM: UI Events & Focus Handling, defect)
Tracking
()
RESOLVED
FIXED
mozilla26
People
(Reporter: bhearsum, Assigned: masayuki)
References
(Blocks 1 open bug, )
Details
(Keywords: regression)
Attachments
(1 file)
1.28 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
Just noticed this on the latest nightly (https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-08-26-03-02-03-mozilla-central/firefox-26.0a1.en-US.linux-x86_64.tar.bz2) -- whenever I paste something into an Etherpad with the keyboard shortcut, it is pasted twice. Doesn't happen if I right click and use the menu item. I can't reproduce in the previous nightly (https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-08-25-03-02-01-mozilla-central/firefox-26.0a1.en-US.linux-x86_64.tar.bz2). Given that it doesn't happen with Bugzilla or other sites, could be a website issue? bug 897885 and 907612 both touch keyboard input and are in the regression range. Masayuki, do you have any insight?
Flags: needinfo?(masayuki)
Assignee | ||
Comment 1•11 years ago
|
||
Yeah, it must be so. Although, I tested with <input> and <textarea>... Hmm, I'll look this tomorrow.
Assignee: nobody → masayuki
Blocks: 907612
Component: General → Widget: Gtk
Flags: needinfo?(masayuki)
Keywords: regression
Product: Firefox → Core
Version: unspecified → Trunk
Assignee | ||
Updated•11 years ago
|
Summary: double pasting in etherpad with keyboard shortcut → double pasting in HTML editor like etherpad with keyboard shortcut
Assignee | ||
Comment 2•11 years ago
|
||
Er, perhaps, I find the cause.
Status: NEW → ASSIGNED
Component: Widget: Gtk → Event Handling
Assignee | ||
Comment 3•11 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&usebuildbot=1&rev=acb831098e04
Assignee | ||
Comment 4•11 years ago
|
||
Comment on attachment 795474 [details] [diff] [review] Patch WalkHandlersInternal() may consume the aKeyEvent if a shortcut is performed. https://bugzilla.mozilla.org/attachment.cgi?id=793969&action=diff nsContentUtils::DOMEventToNativeKeyEvent() has checked it. So, we need to check if the event has already consumed before passing aKeyEvent to nsINativeKeyBindings. BTW, I feel our key bindings (WalkHandlersInternal()) should be performed after native key bindings don't consume the event. Although, this is out of scope of this bug.
Attachment #795474 -
Flags: review?(roc)
Comment on attachment 795474 [details] [diff] [review] Patch Review of attachment 795474 [details] [diff] [review]: ----------------------------------------------------------------- I'm not really the right person for this.
Attachment #795474 -
Flags: review?(roc) → review?(bugs)
Comment 6•11 years ago
|
||
Confirm this bug for right click paste. Mozilla/5.0 (X11; Linux x86_64; rv:26.0) Gecko/20100101 Firefox/26.0 ID:20130826190748 CSet: c0d1baa50a64
Assignee | ||
Comment 7•11 years ago
|
||
(In reply to Raul Malea from comment #6) > Confirm this bug for right click paste. What did you mean? Pasting from context menu causes same bug??
Comment 8•11 years ago
|
||
(In reply to Masayuki Nakano (:masayuki) (Mozilla Japan) from comment #7) > (In reply to Raul Malea from comment #6) > > Confirm this bug for right click paste. > > What did you mean? Pasting from context menu causes same bug?? Yes. Double posting.
Assignee | ||
Comment 9•11 years ago
|
||
(In reply to Raul Malea from comment #8) > (In reply to Masayuki Nakano (:masayuki) (Mozilla Japan) from comment #7) > > (In reply to Raul Malea from comment #6) > > > Confirm this bug for right click paste. > > > > What did you mean? Pasting from context menu causes same bug?? > > Yes. Double posting. Hmm, I cannot reproduce it with the testcase... Bug 907612 and this bug do NOT touch mouse event handling, though. Bug 907612 changes native key binding manager interface. And it regressed because I forgot to check if the key event is already default prevented before passing key event to the native key binding manager. So, it shouldn't regress the action of context menu.
Comment 10•11 years ago
|
||
Comment on attachment 795474 [details] [diff] [review] Patch A test would be good.
Attachment #795474 -
Flags: review?(bugs) → review+
Assignee | ||
Comment 11•11 years ago
|
||
It's impossible to test this because snynthesizeNativeKey isn't implemented on GTK.
Assignee | ||
Comment 12•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/3e064e6246aa
Comment 13•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/3e064e6246aa
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
Updated•5 years ago
|
Component: Event Handling → User events and focus handling
You need to log in
before you can comment on or make changes to this bug.
Description
•