Closed
Bug 909343
Opened 12 years ago
Closed 12 years ago
[Clock] Refactor and centralize Date Math for Alarm, Timer and Stopwatch
Categories
(Firefox OS Graveyard :: Gaia::Clock, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: protonk, Assigned: protonk)
References
Details
Attachments
(1 file)
Move all date math computation to Utils in order to increase test coverage and permit further refactoring.
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #800249 -
Flags: review?(mike)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 800249 [details] [review]
Pull request on github
Alrighty! I've left my feedback on the GitHub pull request. Let me know if you have any questions, there or in person
Attachment #800249 -
Flags: review?(mike)
|
|
Assignee | |
Updated•12 years ago
|
Attachment #800249 -
Flags: review?(mike)
|
|
||
Comment 3•12 years ago
|
||
Comment on attachment 800249 [details] [review]
Pull request on github
Looks good to me. I'll land post-haste
Attachment #800249 -
Flags: review?(mike) → review+
|
|
||
Comment 4•12 years ago
|
||
master: https://github.com/mozilla-b2g/gaia/commit/b77dc7d399c14ac2bafe5c89566b292bc6772d32
Nice work, Adam!
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
|
||
Comment 5•12 years ago
|
||
|
||
Updated•12 years ago
|
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in
before you can comment on or make changes to this bug.
Description
•