909372 - [Gallery] Improve view activity saving feature robustness

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Gallery, defect)

Description

[:gerard-majax]

Bug 895726 showed that we should not trust the incoming filename completely. We will ensure that the extension matches the blob mime type so that saving to a specific device storage will not fail.

Comment 1

[David Flanagan [:djf]]

I'd suggest that the best way to fix this is to test the filename for correctness before displaying the Save button.  If the filename is invalid, don't allow the user to save.  I think this is better than allowing the user to save with a modified filename.  This way we don't break, but we don't do something different than what was requested by the invoking app.

Comment 2

[Aras Balali Moghaddam]

Hi, this bug looks interesting to me. I will start working on it, if there are no objections.

Comment 3

[John Hu [:johnhu][:johu][:醬糊小弟]]

Aras is working on this bug. I change the assignee to him. Thanks Aras.

Comment 4

[Aras Balali Moghaddam]

Attachment: bug-909372-PR.html

John Hu, thanks for your help with this issue. I am setting you as the reviewer since you are familiar with this bug and solution.

Comment 5

[John Hu [:johnhu][:johu][:醬糊小弟]]

Comment on attachment 803449 [details]
bug-909372-PR.html

Thanks for this patch. r=me.

Comment 6

[John Hu [:johnhu][:johu][:醬糊小弟]]

merged to master:
https://github.com/mozilla-b2g/gaia/commit/a8ae01b29d25f9bf7cdb4199ddbca0a6c7bde514

Comment 7

[Hema Koka [:hema]]

Did this make it to 1.2 (looks like it was merged right about when 1.2 branching happened). John or Aras - could you confirm?

Comment 8

[John Hu [:johnhu][:johu][:醬糊小弟]]

Hema,

I can confirm that it is merged to 1.2.