909374 - [Video] Improve view activity saving feature robustness

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Video, defect)

Description

[:gerard-majax]

Bug 895726 showed that we should not trust the incoming filename completely. We will ensure that the extension matches the blob mime type so that saving to a specific device storage will not fail.

Comment 1

[David Flanagan [:djf]]

I'd suggest that the best way to fix this is to test the filename for correctness before displaying the Save button.  If the filename is invalid, don't allow the user to save.  I think this is better than allowing the user to save with a modified filename.  This way we don't break, but we don't do something different than what was requested by the invoking app.

Comment 2

[John Hu [:johnhu][:johu][:醬糊小弟]]

I think this one should wait for bug 895726 landed before starting. Bug 895726 will add more utils functions which can be reused by this one.

Comment 3

[John Hu [:johnhu][:johu][:醬糊小弟]]

The patch of bug 895726 can be used in this bug. I make this bug depends on bug 895726

Comment 4

[John Hu [:johnhu][:johu][:醬糊小弟]]

Attachment: add the code to check filename and type consistency.

Add the code to check the consistency between filename and blob.type.

Comment 5

[David Flanagan [:djf]]

Comment on attachment 799240 [details]
add the code to check filename and type consistency.

Looks good. Thanks!

Comment 6

[John Hu [:johnhu][:johu][:醬糊小弟]]

merged to master:
https://github.com/mozilla-b2g/gaia/commit/7f787b8dc9026dba5d9a0a8b33719f5b08ecddca