909386 - [Clock] Refactor Stopwatch API

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Clock, defect)

Description

[Evelyn Eastmond [:evhan55]]

Refactor and re-implement Stopwatch API.  Write tests for it.

Comment 1

[Eric O'Connor [:oconnore]]

Update to reflect User Story dependencies

Comment 2

[Evelyn Eastmond [:evhan55]]

Attachment: https://github.com/mozilla-b2g/gaia/pull/11846

New Stopwatch API

start() starts the stopwatch
getElapsedTime() gets a Date object storing the duration since starting the stopwatch
pause() pauses the stopwatch
lap() returns a Date object storing the duration since the last lap, or if no last lap, since starting the stopwatch
reset() sets the stopwatch's elapsed time back to 0

Tests

tested the API functions in their own suites, leaving out start() since its encompassed by the test for getElapsedTime()

Questions

not sure if the view needs the model to return a list of all lap times, can the view handle that list itself?

Comment 3

[Mike Pennisi [:jugglinmike]]

Comment on attachment 797424 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/11846

This is a good first pass, Evelyn! I've left comments on the pull request on GitHub. Please re-set the "review" flag when you'd like me to take another look.

Comment 4

[Evelyn Eastmond [:evhan55]]

Wooh, thanks, captain! Will do!

Comment 5

[Mike Pennisi [:jugglinmike]]

Comment on attachment 797424 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/11846

Looking good, Evelyn! I'll merge this post-haste

Comment 6

[Mike Pennisi [:jugglinmike]]

master: https://github.com/mozilla-b2g/gaia/commit/6879d212d8f0030d64e30441dd4cdfc16415478e

Nice work :)

Comment 7

[Evelyn Eastmond [:evhan55]]

hooray!

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/3335f50ebaba

Comment 9

[Mike Pennisi [:jugglinmike]]

Comment on attachment 797424 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/11846

Looks like I forgot to set the review flag on the patch (which has since landed in master). Setting it now for bookkeeping purposes.