909466 - The find toolbar overflows into the sidebar

Status: VERIFIED FIXED

(Toolkit :: Find Toolbar, defect, P5)

Description

[Florian Quèze [:florian]]

Attachment: Screenshot

Steps to reproduce:
In a window that isn't very wide and has a visible SocialAPI sidebar, open the findbar (Command+f), type something, then press F3 until it reaches the end of the page.

Comment 1

[Florian Quèze [:florian]]

Attachment: Fix

Comment 2

[Dão Gottwald [:dao]]

Comment on attachment 796739 [details] [diff] [review]
Fix

I think the right fix here is probably to allow the status message to be cropped with an ellipsis and add it as a tooltip such that the user can still read the full message.

Comment 3

[Florian Quèze [:florian]]

(In reply to Dão Gottwald [:dao] from comment #2)

> I think the right fix here is probably to allow the status message to be
> cropped with an ellipsis

Do you mean this in addition to hiding the overflow?

In the screenshot I attached, even without the status message, there's not enough horizontal space for the "Highlight all" and "Match case" buttons.

Comment 4

[Dão Gottwald [:dao]]

I suppose we could also make the input field flexible to allow the find bar to consume even less space. But I'm not sure that's worth worrying about at that point. The screenshot seems like an edge case.

Comment 5

[Florian Quèze [:florian]]

(In reply to Dão Gottwald [:dao] from comment #2)
> Comment on attachment 796739 [details] [diff] [review]
> Fix
> 
> I think the right fix here is probably to allow the status message to be
> cropped with an ellipsis

I don't see any way to do this without reverting bug 371279. The crop attribute doesn't seem to work on description tags.

Comment 6

[Florian Quèze [:florian]]

As I said in comment 5, I don't see any way to crop the status message without likely regressing an accessibility fix (bug 371279). So unless I missed something (please tell me what :-)), hiding the overflow like attachment 796739 [details] [diff] [review] does seems the best thing to do.

Comment 7

[Dão Gottwald [:dao]]

You should probably ask some a11y people about this. Bug 371279 seems like a hack that shouldn't be necessary. Maybe it's already obsolete today.

It has also been suggested that we should just remove the "reached end of page" status message in bug 257061 comment 106.

Comment 8

[Florian Quèze [:florian]]

Attachment: Screenshot with bookmarks sidebar

The SocialAPI toolbar no longer exists, but I can reproduce with the bookmark sidebar and the searchbar's search field. See attached screenshot.

Comment 9

[Florian Quèze [:florian]]

Attachment: Fix v2

Comment 10

[Florian Quèze [:florian]]

Comment on attachment 8939844 [details] [diff] [review]
Fix v2

The same fix as what I had in attachment 796739 [details] [diff] [review] still works, it just needs to be applied in a different file now.

Comment 11

[:Gijs (he/him)]

Comment on attachment 8939844 [details] [diff] [review]
Fix v2

Review of attachment 8939844 [details] [diff] [review]:
-----------------------------------------------------------------

Not having the garbled appearance in the screenshots and just hiding the overflowing bits seems strictly better than the status quo, and AIUI this change doesn't make anything else worse, so rs=me, I guess.

However, as has been suggested elsewhere in this bug, perhaps we need some more serious work to make the find bar useful on narrower window sizes and/or with the sidebar open.

Can you file a followup and ping UX?

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0015a2d814c3
The find toolbar should not overflow into the sidebar, r=Gijs.

Comment 13

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/0015a2d814c3

Comment 14

[Oana Botisan, Desktop QA]

I managed to reproduce the bug using an older version of Nightly (2018-01-04) on macOS 10.13.
I retested everything on macOS 10.13 using latest Nightly 60.0a1 and beta 59.0b6 and the bug is not reproducing anymore. It has the same behaviour as it does on Windows and Ubuntu.