Closed
Bug 909466
Opened 11 years ago
Closed 6 years ago
The find toolbar overflows into the sidebar
Categories
(Toolkit :: Find Toolbar, defect, P5)
Toolkit
Find Toolbar
Tracking
()
VERIFIED
FIXED
mozilla59
People
(Reporter: florian, Assigned: florian)
References
(Depends on 1 open bug)
Details
Attachments
(2 files, 2 obsolete files)
41.85 KB,
image/png
|
Details | |
890 bytes,
patch
|
Gijs
:
review+
|
Details | Diff | Splinter Review |
Steps to reproduce: In a window that isn't very wide and has a visible SocialAPI sidebar, open the findbar (Command+f), type something, then press F3 until it reaches the end of the page.
Assignee | ||
Comment 1•11 years ago
|
||
Assignee: nobody → florian
Attachment #796739 -
Flags: review?(enndeakin)
Updated•11 years ago
|
Attachment #796739 -
Flags: review?(enndeakin) → review?(dao)
Comment 2•11 years ago
|
||
Comment on attachment 796739 [details] [diff] [review] Fix I think the right fix here is probably to allow the status message to be cropped with an ellipsis and add it as a tooltip such that the user can still read the full message.
Attachment #796739 -
Flags: review?(dao) → review-
Assignee | ||
Comment 3•11 years ago
|
||
(In reply to Dão Gottwald [:dao] from comment #2) > I think the right fix here is probably to allow the status message to be > cropped with an ellipsis Do you mean this in addition to hiding the overflow? In the screenshot I attached, even without the status message, there's not enough horizontal space for the "Highlight all" and "Match case" buttons.
Comment 4•11 years ago
|
||
I suppose we could also make the input field flexible to allow the find bar to consume even less space. But I'm not sure that's worth worrying about at that point. The screenshot seems like an edge case.
Assignee | ||
Comment 5•11 years ago
|
||
(In reply to Dão Gottwald [:dao] from comment #2) > Comment on attachment 796739 [details] [diff] [review] > Fix > > I think the right fix here is probably to allow the status message to be > cropped with an ellipsis I don't see any way to do this without reverting bug 371279. The crop attribute doesn't seem to work on description tags.
Assignee | ||
Comment 6•11 years ago
|
||
As I said in comment 5, I don't see any way to crop the status message without likely regressing an accessibility fix (bug 371279). So unless I missed something (please tell me what :-)), hiding the overflow like attachment 796739 [details] [diff] [review] does seems the best thing to do.
Flags: needinfo?(dao)
OS: Mac OS X → All
Hardware: x86 → All
Comment 7•11 years ago
|
||
You should probably ask some a11y people about this. Bug 371279 seems like a hack that shouldn't be necessary. Maybe it's already obsolete today. It has also been suggested that we should just remove the "reached end of page" status message in bug 257061 comment 106.
Flags: needinfo?(dao)
Updated•11 years ago
|
Blocks: Instantbird
Updated•8 years ago
|
Priority: -- → P5
Assignee | ||
Comment 8•6 years ago
|
||
The SocialAPI toolbar no longer exists, but I can reproduce with the bookmark sidebar and the searchbar's search field. See attached screenshot.
Attachment #795595 -
Attachment is obsolete: true
Assignee | ||
Updated•6 years ago
|
Assignee: florian → nobody
Summary: The find toolbar overflows into the SocialAPI sidebar → The find toolbar overflows into the sidebar
Assignee | ||
Comment 9•6 years ago
|
||
Assignee | ||
Updated•6 years ago
|
Attachment #796739 -
Attachment is obsolete: true
Assignee | ||
Comment 10•6 years ago
|
||
Comment on attachment 8939844 [details] [diff] [review] Fix v2 The same fix as what I had in attachment 796739 [details] [diff] [review] still works, it just needs to be applied in a different file now.
Attachment #8939844 -
Attachment description: The find toolbar should not overflow into the sidebar, → Fix v2
Attachment #8939844 -
Flags: review?(gijskruitbosch+bugs)
Comment 11•6 years ago
|
||
Comment on attachment 8939844 [details] [diff] [review] Fix v2 Review of attachment 8939844 [details] [diff] [review]: ----------------------------------------------------------------- Not having the garbled appearance in the screenshots and just hiding the overflowing bits seems strictly better than the status quo, and AIUI this change doesn't make anything else worse, so rs=me, I guess. However, as has been suggested elsewhere in this bug, perhaps we need some more serious work to make the find bar useful on narrower window sizes and/or with the sidebar open. Can you file a followup and ping UX?
Attachment #8939844 -
Flags: review?(gijskruitbosch+bugs) → review+
Comment 12•6 years ago
|
||
Pushed by florian@queze.net: https://hg.mozilla.org/integration/mozilla-inbound/rev/0015a2d814c3 The find toolbar should not overflow into the sidebar, r=Gijs.
Comment 13•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/0015a2d814c3
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Updated•6 years ago
|
Flags: qe-verify+
Comment 14•6 years ago
|
||
I managed to reproduce the bug using an older version of Nightly (2018-01-04) on macOS 10.13. I retested everything on macOS 10.13 using latest Nightly 60.0a1 and beta 59.0b6 and the bug is not reproducing anymore. It has the same behaviour as it does on Windows and Ubuntu.
Updated•6 years ago
|
Assignee: nobody → florian
You need to log in
before you can comment on or make changes to this bug.
Description
•